note that treating all base64 values as binary is bad

diff --git a/moonshot/mech_eap/util_shib.cpp b/moonshot/mech_eap/util_shib.cpp
index a83a7ea..0ee894b 100644 (file)
--- a/moonshot/mech_eap/util_shib.cpp
+++ b/moonshot/mech_eap/util_shib.cpp
@@ -304,6 +304,7 @@ gss_eap_shib_attr_provider::getAttribute(const gss_buffer_t attr,
     buf.value = (void *)shibAttr->getSerializedValues()[*more].c_str();
     buf.length = strlen((char *)buf.value);
 
     buf.value = (void *)shibAttr->getSerializedValues()[*more].c_str();
     buf.length = strlen((char *)buf.value);
 

+    /* FIXME treating all valid base64 values as binary is bad */

     if (base64Valid((char *)buf.value)) {
         ssize_t octetLen;
 
     if (base64Valid((char *)buf.value)) {
         ssize_t octetLen;