Refuse to process handlers with no Location.

git-svn-id: https://svn.middleware.georgetown.edu/cpp-sp/branches/REL_2@3256 cb58f699-b61c-0410-a6fe-9272a202ed29

diff --git a/shibsp/impl/XMLServiceProvider.cpp b/shibsp/impl/XMLServiceProvider.cpp
index c7efee5..d052a9e 100644 (file)
--- a/shibsp/impl/XMLServiceProvider.cpp
+++ b/shibsp/impl/XMLServiceProvider.cpp
@@ -632,9 +632,13 @@ XMLApplication::XMLApplication(
         bool hardACS=false, hardSessionInit=false, hardArt=false;
         const DOMElement* child = sessions ? XMLHelper::getFirstChildElement(sessions->getElement()) : nullptr;
         while (child) {
+            if (!child->hasAttributeNS(nullptr, Location)) {
+                auto_ptr_char hclass(child->getLocalName());
+                log.error("%s handler with no Location property cannot be processed", hclass.get());
+                child = XMLHelper::getNextSiblingElement(child);
+                continue;
+            }
             try {
-                // A handler is based on the Binding property in conjunction with the element name.
-                // If it's an ACS or SI, also handle index/id mappings and defaulting.
                 if (XMLString::equals(child->getLocalName(),_AssertionConsumerService)) {
                     auto_ptr_char bindprop(child->getAttributeNS(nullptr,Binding));
                     if (!bindprop.get() || !*(bindprop.get())) {