Add a comment to revisit a difference between this module and the

other apache2 module (a bit of logic where apache-1.3 and apache-2.0
differ).  Should we return OK or DECLINED?

git-svn-id: https://svn.middleware.georgetown.edu/cpp-sp/trunk@929 cb58f699-b61c-0410-a6fe-9272a202ed29

diff --git a/apache/mod_apache.cpp b/apache/mod_apache.cpp
index 386b8e7..da5ead4 100644 (file)
--- a/apache/mod_apache.cpp
+++ b/apache/mod_apache.cpp
@@ -269,7 +269,7 @@ extern "C" int shib_check_user(request_rec* r)
 
         // If no session required, bail now.
         if (!requireSession.second)
-            return DECLINED;
+            return DECLINED;   // XXX: Or should this be OK?
         else if (status->isRetryable()) {
             // Oops, session is invalid. Generate AuthnRequest.
             ap_table_setn(r->headers_out,"Location",ap_pstrdup(r->pool,shire.getAuthnRequest(targeturl)));