Use strncmp instead of strcmp in tr_name_cmp().
authorJennifer Richards <jennifer@painless-security.com>
Tue, 17 May 2016 18:28:08 +0000 (14:28 -0400)
committerJennifer Richards <jennifer@painless-security.com>
Tue, 17 May 2016 18:28:08 +0000 (14:28 -0400)
common/tr_name.c

index 0e15595..7e8b14f 100644 (file)
@@ -82,9 +82,10 @@ int tr_name_cmp(TR_NAME *one, TR_NAME *two)
 {
   if (one->len != two->len)
     return 1;
-  else 
-    /* TBD -- should really do a length-based comparison */
-    return strcmp(one->buf, two->buf);
+  else {
+    /* lengths equal */
+    return strncmp(one->buf, two->buf, one->len);
+  }
 }
 
 void tr_name_strlcat(char *dest, const TR_NAME *src, size_t len)