src/main/conffile.c

   1 /*
   2  * conffile.c   Read the radiusd.conf file.
   3  *
   4  *              Yep I should learn to use lex & yacc, or at least
   5  *              write a decent parser. I know how to do that, really :)
   6  *              miquels@cistron.nl
   7  *
   8  * Version:     $Id$
   9  *
  10  *   This program is free software; you can redistribute it and/or modify
  11  *   it under the terms of the GNU General Public License as published by
  12  *   the Free Software Foundation; either version 2 of the License, or
  13  *   (at your option) any later version.
  14  *
  15  *   This program is distributed in the hope that it will be useful,
  16  *   but WITHOUT ANY WARRANTY; without even the implied warranty of
  17  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  18  *   GNU General Public License for more details.
  19  *
  20  *   You should have received a copy of the GNU General Public License
  21  *   along with this program; if not, write to the Free Software
  22  *   Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  23  *
  24  * Copyright 2000,2006  The FreeRADIUS server project
  25  * Copyright 2000  Miquel van Smoorenburg <miquels@cistron.nl>
  26  * Copyright 2000  Alan DeKok <aland@ox.org>
  27  */
  28
  29 RCSID("$Id$")
  30
  31 #include <freeradius-devel/radiusd.h>
  32 #include <freeradius-devel/parser.h>
  33 #include <freeradius-devel/rad_assert.h>
  34
  35 #ifdef HAVE_DIRENT_H
  36 #include <dirent.h>
  37 #endif
  38
  39 #ifdef HAVE_SYS_STAT_H
  40 #include <sys/stat.h>
  41 #endif
  42
  43 #include <ctype.h>
  44
  45 bool check_config = false;
  46
  47 typedef enum conf_property {
  48         CONF_PROPERTY_INVALID = 0,
  49         CONF_PROPERTY_NAME,
  50         CONF_PROPERTY_INSTANCE,
  51 } CONF_PROPERTY;
  52
  53 static const FR_NAME_NUMBER conf_property_name[] = {
  54         { "name",       CONF_PROPERTY_NAME},
  55         { "instance",   CONF_PROPERTY_INSTANCE},
  56
  57         {  NULL , -1 }
  58 };
  59
  60 typedef enum conf_type {
  61         CONF_ITEM_INVALID = 0,
  62         CONF_ITEM_PAIR,
  63         CONF_ITEM_SECTION,
  64         CONF_ITEM_DATA
  65 } CONF_ITEM_TYPE;
  66
  67 struct conf_item {
  68         struct conf_item *next;         //!< Sibling.
  69         struct conf_part *parent;       //!< Parent.
  70         int lineno;                     //!< The line number the config item began on.
  71         char const *filename;           //!< The file the config item was parsed from.
  72         CONF_ITEM_TYPE type;            //!< Whether the config item is a config_pair, conf_section or conf_data.
  73 };
  74
  75 /** Configuration AVP similar to a VALUE_PAIR
  76  *
  77  */
  78 struct conf_pair {
  79         CONF_ITEM       item;
  80         char const      *attr;          //!< Attribute name
  81         char const      *value;         //!< Attribute value
  82         FR_TOKEN        op;             //!< Operator e.g. =, :=
  83         FR_TOKEN        lhs_type;       //!< Name quoting style T_(DOUBLE|SINGLE|BACK)_QUOTE_STRING or T_BARE_WORD.
  84         FR_TOKEN        rhs_type;       //!< Value Quoting style T_(DOUBLE|SINGLE|BACK)_QUOTE_STRING or T_BARE_WORD.
  85         bool            pass2;          //!< do expansion in pass2.
  86         bool            parsed;         //!< Was this item used during parsing?
  87 };
  88
  89 /** Internal data that is associated with a configuration section
  90  *
  91  */
  92 struct conf_data {
  93         CONF_ITEM       item;
  94         char const      *name;
  95         int             flag;
  96         void            *data;          //!< User data
  97         void            (*free)(void *);        //!< Free user data function
  98 };
  99
 100 struct conf_part {
 101         CONF_ITEM       item;
 102         char const      *name1;         //!< First name token.  Given ``foo bar {}`` would be ``foo``.
 103         char const      *name2;         //!< Second name token. Given ``foo bar {}`` would be ``bar``.
 104
 105         FR_TOKEN        name2_type;     //!< The type of quoting around name2.
 106
 107         CONF_ITEM       *children;
 108         CONF_ITEM       *tail;          //!< For speed.
 109         CONF_SECTION    *template;
 110
 111         rbtree_t        *pair_tree;     //!< and a partridge..
 112         rbtree_t        *section_tree;  //!< no jokes here.
 113         rbtree_t        *name2_tree;    //!< for sections of the same name2
 114         rbtree_t        *data_tree;
 115
 116         void            *base;
 117         int             depth;
 118
 119         CONF_PARSER const *variables;
 120 };
 121
 122 typedef struct cf_file_t {
 123         char const      *filename;
 124         CONF_SECTION    *cs;
 125         struct stat     buf;
 126 } cf_file_t;
 127
 128 CONF_SECTION *root_config = NULL;
 129 bool cf_new_escape = false;
 130
 131
 132 static int              cf_data_add_internal(CONF_SECTION *cs, char const *name, void *data,
 133                                              void (*data_free)(void *), int flag);
 134
 135 static void             *cf_data_find_internal(CONF_SECTION const *cs, char const *name, int flag);
 136
 137 static char const       *cf_expand_variables(char const *cf, int *lineno,
 138                                              CONF_SECTION *outercs,
 139                                              char *output, size_t outsize,
 140                                              char const *input, bool *soft_fail);
 141
 142 static int cf_file_include(CONF_SECTION *cs, char const *filename_in);
 143
 144
 145
 146 /*
 147  *      Isolate the scary casts in these tiny provably-safe functions
 148  */
 149
 150 /** Cast a CONF_ITEM to a CONF_PAIR
 151  *
 152  */
 153 CONF_PAIR *cf_item_to_pair(CONF_ITEM const *ci)
 154 {
 155         CONF_PAIR *out;
 156
 157         if (ci == NULL) return NULL;
 158
 159         rad_assert(ci->type == CONF_ITEM_PAIR);
 160
 161         memcpy(&out, &ci, sizeof(out));
 162         return out;
 163 }
 164
 165 /** Cast a CONF_ITEM to a CONF_SECTION
 166  *
 167  */
 168 CONF_SECTION *cf_item_to_section(CONF_ITEM const *ci)
 169 {
 170         CONF_SECTION *out;
 171
 172         if (ci == NULL) return NULL;
 173
 174         rad_assert(ci->type == CONF_ITEM_SECTION);
 175
 176         memcpy(&out, &ci, sizeof(out));
 177         return out;
 178 }
 179
 180 /** Cast a CONF_PAIR to a CONF_ITEM
 181  *
 182  */
 183 CONF_ITEM *cf_pair_to_item(CONF_PAIR const *cp)
 184 {
 185         CONF_ITEM *out;
 186
 187         if (cp == NULL) return NULL;
 188
 189         memcpy(&out, &cp, sizeof(out));
 190         return out;
 191 }
 192
 193 /** Cast a CONF_SECTION to a CONF_ITEM
 194  *
 195  */
 196 CONF_ITEM *cf_section_to_item(CONF_SECTION const *cs)
 197 {
 198         CONF_ITEM *out;
 199
 200         if (cs == NULL) return NULL;
 201
 202         memcpy(&out, &cs, sizeof(out));
 203         return out;
 204 }
 205
 206 /** Cast CONF_DATA to a CONF_ITEM
 207  *
 208  */
 209 static CONF_ITEM *cf_data_to_item(CONF_DATA const *cd)
 210 {
 211         CONF_ITEM *out;
 212
 213         if (cd == NULL) {
 214                 return NULL;
 215         }
 216
 217         memcpy(&out, &cd, sizeof(out));
 218         return out;
 219 }
 220
 221 static int _cf_data_free(CONF_DATA *cd)
 222 {
 223         if (cd->free) cd->free(cd->data);
 224
 225         return 0;
 226 }
 227
 228 /*
 229  *      rbtree callback function
 230  */
 231 static int pair_cmp(void const *a, void const *b)
 232 {
 233         CONF_PAIR const *one = a;
 234         CONF_PAIR const *two = b;
 235
 236         return strcmp(one->attr, two->attr);
 237 }
 238
 239
 240 /*
 241  *      rbtree callback function
 242  */
 243 static int section_cmp(void const *a, void const *b)
 244 {
 245         CONF_SECTION const *one = a;
 246         CONF_SECTION const *two = b;
 247
 248         return strcmp(one->name1, two->name1);
 249 }
 250
 251
 252 /*
 253  *      rbtree callback function
 254  */
 255 static int name2_cmp(void const *a, void const *b)
 256 {
 257         CONF_SECTION const *one = a;
 258         CONF_SECTION const *two = b;
 259
 260         rad_assert(strcmp(one->name1, two->name1) == 0);
 261
 262         if (!one->name2 && !two->name2) return 0;
 263         if (one->name2 && !two->name2) return -1;
 264         if (!one->name2 && two->name2) return +1;
 265
 266         return strcmp(one->name2, two->name2);
 267 }
 268
 269
 270 /*
 271  *      rbtree callback function
 272  */
 273 static int data_cmp(void const *a, void const *b)
 274 {
 275         int rcode;
 276
 277         CONF_DATA const *one = a;
 278         CONF_DATA const *two = b;
 279
 280         rcode = one->flag - two->flag;
 281         if (rcode != 0) return rcode;
 282
 283         return strcmp(one->name, two->name);
 284 }
 285
 286 /*
 287  *      Functions for tracking filenames.
 288  */
 289 static int filename_cmp(void const *a, void const *b)
 290 {
 291         cf_file_t const *one = a;
 292         cf_file_t const *two = b;
 293
 294         if (one->buf.st_dev < two->buf.st_dev) return -1;
 295         if (one->buf.st_dev > two->buf.st_dev) return +1;
 296
 297         if (one->buf.st_ino < two->buf.st_ino) return -1;
 298         if (one->buf.st_ino > two->buf.st_ino) return +1;
 299
 300         return 0;
 301 }
 302
 303 static FILE *cf_file_open(CONF_SECTION *cs, char const *filename)
 304 {
 305         cf_file_t *file;
 306         CONF_DATA *cd;
 307         CONF_SECTION *top;
 308         rbtree_t *tree;
 309         int fd;
 310         FILE *fp;
 311
 312         top = cf_top_section(cs);
 313         cd = cf_data_find_internal(top, "filename", 0);
 314         if (!cd) return NULL;
 315
 316         tree = cd->data;
 317
 318         fp = fopen(filename, "r");
 319         if (!fp) {
 320                 ERROR("Unable to open file \"%s\": %s",
 321                       filename, fr_syserror(errno));
 322                 return NULL;
 323         }
 324
 325         fd = fileno(fp);
 326
 327         file = talloc(tree, cf_file_t);
 328         if (!file) {
 329                 fclose(fp);
 330                 return NULL;
 331         }
 332
 333         file->filename = filename;
 334         file->cs = cs;
 335
 336         if (fstat(fd, &file->buf) == 0) {
 337 #ifdef S_IWOTH
 338                 if ((file->buf.st_mode & S_IWOTH) != 0) {
 339                         ERROR("Configuration file %s is globally writable.  "
 340                               "Refusing to start due to insecure configuration.", filename);
 341
 342                         fclose(fp);
 343                         talloc_free(file);
 344                         return NULL;
 345                 }
 346 #endif
 347         }
 348
 349         /*
 350          *      We can include the same file twice.  e.g. when it
 351          *      contains common definitions, such as for SQL.
 352          *
 353          *      Though the admin should really use templates for that.
 354          */
 355         if (!rbtree_insert(tree, file)) {
 356                 talloc_free(file);
 357         }
 358
 359         return fp;
 360 }
 361
 362 /*
 363  *      Do some checks on the file
 364  */
 365 static bool cf_file_check(CONF_SECTION *cs, char const *filename, bool check_perms)
 366 {
 367         cf_file_t *file;
 368         CONF_DATA *cd;
 369         CONF_SECTION *top;
 370         rbtree_t *tree;
 371
 372         top = cf_top_section(cs);
 373         cd = cf_data_find_internal(top, "filename", 0);
 374         if (!cd) return false;
 375
 376         tree = cd->data;
 377
 378         file = talloc(tree, cf_file_t);
 379         if (!file) return false;
 380
 381         file->filename = filename;
 382         file->cs = cs;
 383
 384         if (stat(filename, &file->buf) < 0) {
 385                 ERROR("Unable to check file \"%s\": %s", filename, fr_syserror(errno));
 386                 talloc_free(file);
 387                 return false;
 388         }
 389
 390         if (!check_perms) {
 391                 talloc_free(file);
 392                 return true;
 393         }
 394
 395 #ifdef S_IWOTH
 396         if ((file->buf.st_mode & S_IWOTH) != 0) {
 397                 ERROR("Configuration file %s is globally writable.  "
 398                       "Refusing to start due to insecure configuration.", filename);
 399                 talloc_free(file);
 400                 return false;
 401         }
 402 #endif
 403
 404         /*
 405          *      It's OK to include the same file twice...
 406          */
 407         if (!rbtree_insert(tree, file)) {
 408                 talloc_free(file);
 409         }
 410
 411         return true;
 412
 413 }
 414
 415
 416 typedef struct cf_file_callback_t {
 417         int             rcode;
 418         rb_walker_t     callback;
 419         CONF_SECTION    *modules;
 420 } cf_file_callback_t;
 421
 422
 423 /*
 424  *      Return 0 for keep going, 1 for stop.
 425  */
 426 static int file_callback(void *ctx, void *data)
 427 {
 428         cf_file_callback_t *cb = ctx;
 429         cf_file_t *file = data;
 430         struct stat buf;
 431
 432         /*
 433          *      The file doesn't exist or we can no longer read it.
 434          */
 435         if (stat(file->filename, &buf) < 0) {
 436                 cb->rcode = CF_FILE_ERROR;
 437                 return 1;
 438         }
 439
 440         /*
 441          *      The file changed, we'll need to re-read it.
 442          */
 443         if (buf.st_mtime != file->buf.st_mtime) {
 444
 445                 if (cb->callback(cb->modules, file->cs)) {
 446                         cb->rcode |= CF_FILE_MODULE;
 447                         DEBUG3("HUP: Changed module file %s", file->filename);
 448                 } else {
 449                         DEBUG3("HUP: Changed config file %s", file->filename);
 450                         cb->rcode |= CF_FILE_CONFIG;
 451                 }
 452         }
 453
 454         return 0;
 455 }
 456
 457
 458 /*
 459  *      See if any of the files have changed.
 460  */
 461 int cf_file_changed(CONF_SECTION *cs, rb_walker_t callback)
 462 {
 463         CONF_DATA *cd;
 464         CONF_SECTION *top;
 465         cf_file_callback_t cb;
 466         rbtree_t *tree;
 467
 468         top = cf_top_section(cs);
 469         cd = cf_data_find_internal(top, "filename", 0);
 470         if (!cd) return true;
 471
 472         tree = cd->data;
 473
 474         cb.rcode = CF_FILE_NONE;
 475         cb.callback = callback;
 476         cb.modules = cf_section_sub_find(cs, "modules");
 477
 478         (void) rbtree_walk(tree, RBTREE_IN_ORDER, file_callback, &cb);
 479
 480         return cb.rcode;
 481 }
 482
 483 static int _cf_section_free(CONF_SECTION *cs)
 484 {
 485         /*
 486          *      Name1 and name2 are allocated contiguous with
 487          *      cs.
 488          */
 489         if (cs->pair_tree) {
 490                 rbtree_free(cs->pair_tree);
 491                 cs->pair_tree = NULL;
 492         }
 493         if (cs->section_tree) {
 494                 rbtree_free(cs->section_tree);
 495                 cs->section_tree = NULL;
 496         }
 497         if (cs->name2_tree) {
 498                 rbtree_free(cs->name2_tree);
 499                 cs->name2_tree = NULL;
 500         }
 501         if (cs->data_tree) {
 502                 rbtree_free(cs->data_tree);
 503                 cs->data_tree = NULL;
 504         }
 505
 506         return 0;
 507 }
 508
 509 /** Allocate a CONF_PAIR
 510  *
 511  * @param parent CONF_SECTION to hang this CONF_PAIR off of.
 512  * @param attr name.
 513  * @param value of CONF_PAIR.
 514  * @param op T_OP_EQ, T_OP_SET etc.
 515  * @param lhs_type T_BARE_WORD, T_DOUBLE_QUOTED_STRING, T_BACK_QUOTED_STRING
 516  * @param rhs_type T_BARE_WORD, T_DOUBLE_QUOTED_STRING, T_BACK_QUOTED_STRING
 517  * @return NULL on error, else a new CONF_SECTION parented by parent.
 518  */
 519 CONF_PAIR *cf_pair_alloc(CONF_SECTION *parent, char const *attr, char const *value,
 520                          FR_TOKEN op, FR_TOKEN lhs_type, FR_TOKEN rhs_type)
 521 {
 522         CONF_PAIR *cp;
 523
 524         rad_assert(fr_equality_op[op] || fr_assignment_op[op]);
 525         if (!attr) return NULL;
 526
 527         cp = talloc_zero(parent, CONF_PAIR);
 528         if (!cp) return NULL;
 529
 530         cp->item.type = CONF_ITEM_PAIR;
 531         cp->item.parent = parent;
 532         cp->lhs_type = lhs_type;
 533         cp->rhs_type = rhs_type;
 534         cp->op = op;
 535
 536         cp->attr = talloc_typed_strdup(cp, attr);
 537         if (!cp->attr) {
 538         error:
 539                 talloc_free(cp);
 540                 return NULL;
 541         }
 542
 543         if (value) {
 544                 cp->value = talloc_typed_strdup(cp, value);
 545                 if (!cp->value) goto error;
 546         }
 547
 548         return cp;
 549 }
 550
 551 /** Duplicate a CONF_PAIR
 552  *
 553  * @param parent to allocate new pair in.
 554  * @param cp to duplicate.
 555  * @return NULL on error, else a duplicate of the input pair.
 556  */
 557 CONF_PAIR *cf_pair_dup(CONF_SECTION *parent, CONF_PAIR *cp)
 558 {
 559         CONF_PAIR *new;
 560
 561         rad_assert(parent);
 562         rad_assert(cp);
 563
 564         new = cf_pair_alloc(parent, cp->attr, cf_pair_value(cp),
 565                             cp->op, cp->lhs_type, cp->rhs_type);
 566         if (!new) return NULL;
 567
 568         new->parsed = cp->parsed;
 569         new->item.lineno = cp->item.lineno;
 570
 571         /*
 572          *      Avoid mallocs if possible.
 573          */
 574         if (!cp->item.filename || (parent->item.filename && !strcmp(parent->item.filename, cp->item.filename))) {
 575                 new->item.filename = parent->item.filename;
 576         } else {
 577                 new->item.filename = talloc_strdup(new, cp->item.filename);
 578         }
 579
 580         return new;
 581 }
 582
 583 /** Add a configuration pair to a section
 584  *
 585  * @param parent section to add pair to.
 586  * @param cp to add.
 587  */
 588 void cf_pair_add(CONF_SECTION *parent, CONF_PAIR *cp)
 589 {
 590         cf_item_add(parent, cf_pair_to_item(cp));
 591 }
 592
 593 /** Allocate a CONF_SECTION
 594  *
 595  * @param parent CONF_SECTION to hang this CONF_SECTION off of.
 596  * @param name1 Primary name.
 597  * @param name2 Secondary name.
 598  * @return NULL on error, else a new CONF_SECTION parented by parent.
 599  */
 600 CONF_SECTION *cf_section_alloc(CONF_SECTION *parent, char const *name1, char const *name2)
 601 {
 602         CONF_SECTION *cs;
 603         char buffer[1024];
 604
 605         if (!name1) return NULL;
 606
 607         if (name2 && parent) {
 608                 if (strchr(name2, '$')) {
 609                         name2 = cf_expand_variables(parent->item.filename,
 610                                                     &parent->item.lineno,
 611                                                     parent,
 612                                                     buffer, sizeof(buffer), name2, NULL);
 613                         if (!name2) {
 614                                 ERROR("Failed expanding section name");
 615                                 return NULL;
 616                         }
 617                 }
 618         }
 619
 620         cs = talloc_zero(parent, CONF_SECTION);
 621         if (!cs) return NULL;
 622
 623         cs->item.type = CONF_ITEM_SECTION;
 624         cs->item.parent = parent;
 625
 626         cs->name1 = talloc_typed_strdup(cs, name1);
 627         if (!cs->name1) {
 628         error:
 629                 talloc_free(cs);
 630                 return NULL;
 631         }
 632
 633         if (name2) {
 634                 cs->name2 = talloc_typed_strdup(cs, name2);
 635                 if (!cs->name2) goto error;
 636         }
 637
 638         cs->pair_tree = rbtree_create(cs, pair_cmp, NULL, 0);
 639         if (!cs->pair_tree) goto error;
 640
 641         talloc_set_destructor(cs, _cf_section_free);
 642
 643         /*
 644          *      Don't create a data tree, it may not be needed.
 645          */
 646
 647         /*
 648          *      Don't create the section tree here, it may not
 649          *      be needed.
 650          */
 651
 652         if (parent) cs->depth = parent->depth + 1;
 653
 654         return cs;
 655 }
 656
 657 /** Duplicate a configuration section
 658  *
 659  * @note recursively duplicates any child sections.
 660  * @note does not duplicate any data associated with a section, or its child sections.
 661  *
 662  * @param parent section (may be NULL).
 663  * @param cs to duplicate.
 664  * @param name1 of new section.
 665  * @param name2 of new section.
 666  * @param copy_meta Copy additional meta data for a section (like template, base, depth and variables).
 667  * @return a duplicate of the existing section, or NULL on error.
 668  */
 669 CONF_SECTION *cf_section_dup(CONF_SECTION *parent, CONF_SECTION const *cs,
 670                              char const *name1, char const *name2, bool copy_meta)
 671 {
 672         CONF_SECTION *new, *subcs;
 673         CONF_PAIR *cp;
 674         CONF_ITEM *ci;
 675
 676         new = cf_section_alloc(parent, name1, name2);
 677
 678         if (copy_meta) {
 679                 new->template = cs->template;
 680                 new->base = cs->base;
 681                 new->depth = cs->depth;
 682                 new->variables = cs->variables;
 683         }
 684
 685         new->item.lineno = cs->item.lineno;
 686
 687         if (!cs->item.filename || (parent && (strcmp(parent->item.filename, cs->item.filename) == 0))) {
 688                 new->item.filename = parent->item.filename;
 689         } else {
 690                 new->item.filename = talloc_strdup(new, cs->item.filename);
 691         }
 692
 693         for (ci = cs->children; ci; ci = ci->next) {
 694                 switch (ci->type) {
 695                 case CONF_ITEM_SECTION:
 696                         subcs = cf_item_to_section(ci);
 697                         subcs = cf_section_dup(new, subcs,
 698                                                cf_section_name1(subcs), cf_section_name2(subcs),
 699                                                copy_meta);
 700                         if (!subcs) {
 701                                 talloc_free(new);
 702                                 return NULL;
 703                         }
 704                         cf_section_add(new, subcs);
 705                         break;
 706
 707                 case CONF_ITEM_PAIR:
 708                         cp = cf_pair_dup(new, cf_item_to_pair(ci));
 709                         if (!cp) {
 710                                 talloc_free(new);
 711                                 return NULL;
 712                         }
 713                         cf_pair_add(new, cp);
 714                         break;
 715
 716                 case CONF_ITEM_DATA: /* Skip data */
 717                         break;
 718
 719                 case CONF_ITEM_INVALID:
 720                         rad_assert(0);
 721                 }
 722         }
 723
 724         return new;
 725 }
 726
 727 void cf_section_add(CONF_SECTION *parent, CONF_SECTION *cs)
 728 {
 729         cf_item_add(parent, &(cs->item));
 730 }
 731
 732 /** Replace pair in a given section with a new pair, of the given value.
 733  *
 734  * @param cs to replace pair in.
 735  * @param cp to replace.
 736  * @param value New value to assign to cp.
 737  * @return 0 on success, -1 on failure.
 738  */
 739 int cf_pair_replace(CONF_SECTION *cs, CONF_PAIR *cp, char const *value)
 740 {
 741         CONF_PAIR *newp;
 742         CONF_ITEM *ci, *cn, **last;
 743
 744         newp = cf_pair_alloc(cs, cp->attr, value, cp->op, cp->lhs_type, cp->rhs_type);
 745         if (!newp) return -1;
 746
 747         ci = &(cp->item);
 748         cn = &(newp->item);
 749
 750         /*
 751          *      Find the old one from the linked list, and replace it
 752          *      with the new one.
 753          */
 754         for (last = &cs->children; (*last) != NULL; last = &(*last)->next) {
 755                 if (*last == ci) {
 756                         cn->next = (*last)->next;
 757                         *last = cn;
 758                         ci->next = NULL;
 759                         break;
 760                 }
 761         }
 762
 763         rbtree_deletebydata(cs->pair_tree, ci);
 764
 765         rbtree_insert(cs->pair_tree, cn);
 766
 767         return 0;
 768 }
 769
 770
 771 /*
 772  *      Add an item to a configuration section.
 773  */
 774 void cf_item_add(CONF_SECTION *cs, CONF_ITEM *ci)
 775 {
 776 #ifndef NDEBUG
 777         CONF_ITEM *first = ci;
 778 #endif
 779
 780         rad_assert((void *)cs != (void *)ci);
 781
 782         if (!cs || !ci) return;
 783
 784         if (!cs->children) {
 785                 rad_assert(cs->tail == NULL);
 786                 cs->children = ci;
 787         } else {
 788                 rad_assert(cs->tail != NULL);
 789                 cs->tail->next = ci;
 790         }
 791
 792         /*
 793          *      Update the trees (and tail) for each item added.
 794          */
 795         for (/* nothing */; ci != NULL; ci = ci->next) {
 796                 rad_assert(ci->next != first);  /* simple cycle detection */
 797
 798                 cs->tail = ci;
 799
 800                 /*
 801                  *      For fast lookups, pairs and sections get
 802                  *      added to rbtree's.
 803                  */
 804                 switch (ci->type) {
 805                 case CONF_ITEM_PAIR:
 806                         if (!rbtree_insert(cs->pair_tree, ci)) {
 807                                 CONF_PAIR *cp = cf_item_to_pair(ci);
 808
 809                                 if (strcmp(cp->attr, "confdir") == 0) break;
 810                                 if (!cp->value) break; /* module name, "ok", etc. */
 811                         }
 812                         break;
 813
 814                 case CONF_ITEM_SECTION: {
 815                         CONF_SECTION *cs_new = cf_item_to_section(ci);
 816                         CONF_SECTION *name1_cs;
 817
 818                         if (!cs->section_tree) {
 819                                 cs->section_tree = rbtree_create(cs, section_cmp, NULL, 0);
 820                                 if (!cs->section_tree) {
 821                                         ERROR("Out of memory");
 822                                         fr_exit_now(1);
 823                                 }
 824                         }
 825
 826                         name1_cs = rbtree_finddata(cs->section_tree, cs_new);
 827                         if (!name1_cs) {
 828                                 if (!rbtree_insert(cs->section_tree, cs_new)) {
 829                                         ERROR("Failed inserting section into tree");
 830                                         fr_exit_now(1);
 831                                 }
 832                                 break;
 833                         }
 834
 835                         /*
 836                          *      We already have a section of
 837                          *      this "name1".  Add a new
 838                          *      sub-section based on name2.
 839                          */
 840                         if (!name1_cs->name2_tree) {
 841                                 name1_cs->name2_tree = rbtree_create(name1_cs, name2_cmp, NULL, 0);
 842                                 if (!name1_cs->name2_tree) {
 843                                         ERROR("Out of memory");
 844                                         fr_exit_now(1);
 845                                 }
 846                         }
 847
 848                         /*
 849                          *      We don't care if this fails.
 850                          *      If the user tries to create
 851                          *      two sections of the same
 852                          *      name1/name2, the duplicate
 853                          *      section is just silently
 854                          *      ignored.
 855                          */
 856                         rbtree_insert(name1_cs->name2_tree, cs_new);
 857                         break;
 858                 } /* was a section */
 859
 860                 case CONF_ITEM_DATA:
 861                         if (!cs->data_tree) {
 862                                 cs->data_tree = rbtree_create(cs, data_cmp, NULL, 0);
 863                         }
 864                         if (cs->data_tree) {
 865                                 rbtree_insert(cs->data_tree, ci);
 866                         }
 867                         break;
 868
 869                 default: /* FIXME: assert & error! */
 870                         break;
 871
 872                 } /* switch over conf types */
 873         } /* loop over ci */
 874 }
 875
 876
 877 CONF_ITEM *cf_reference_item(CONF_SECTION const *parentcs,
 878                              CONF_SECTION *outercs,
 879                              char const *ptr)
 880 {
 881         CONF_PAIR *cp;
 882         CONF_SECTION *next;
 883         CONF_SECTION const *cs = outercs;
 884         char name[8192];
 885         char *p;
 886
 887         if (!cs) goto no_such_item;
 888
 889         strlcpy(name, ptr, sizeof(name));
 890         p = name;
 891
 892         /*
 893          *      ".foo" means "foo from the current section"
 894          */
 895         if (*p == '.') {
 896                 p++;
 897
 898                 /*
 899                  *      Just '.' means the current section
 900                  */
 901                 if (*p == '\0') {
 902                         return cf_section_to_item(cs);
 903                 }
 904
 905                 /*
 906                  *      ..foo means "foo from the section
 907                  *      enclosing this section" (etc.)
 908                  */
 909                 while (*p == '.') {
 910                         if (cs->item.parent) {
 911                                 cs = cs->item.parent;
 912                         }
 913
 914                         /*
 915                          *      .. means the section
 916                          *      enclosing this section
 917                          */
 918                         if (!*++p) {
 919                                 return cf_section_to_item(cs);
 920                         }
 921                 }
 922
 923                 /*
 924                  *      "foo.bar.baz" means "from the root"
 925                  */
 926         } else if (strchr(p, '.') != NULL) {
 927                 if (!parentcs) goto no_such_item;
 928
 929                 cs = parentcs;
 930         }
 931
 932         while (*p) {
 933                 char *q, *r;
 934
 935                 r = strchr(p, '[');
 936                 q = strchr(p, '.');
 937                 if (!r && !q) break;
 938
 939                 if (r && q > r) q = NULL;
 940                 if (q && q < r) r = NULL;
 941
 942                 /*
 943                  *      Split off name2.
 944                  */
 945                 if (r) {
 946                         q = strchr(r + 1, ']');
 947                         if (!q) return NULL; /* parse error */
 948
 949                         /*
 950                          *      Points to foo[bar]xx: parse error,
 951                          *      it should be foo[bar] or foo[bar].baz
 952                          */
 953                         if (q[1] && q[1] != '.') goto no_such_item;
 954
 955                         *r = '\0';
 956                         *q = '\0';
 957                         next = cf_section_sub_find_name2(cs, p, r + 1);
 958                         *r = '[';
 959                         *q = ']';
 960
 961                         /*
 962                          *      Points to a named instance of a section.
 963                          */
 964                         if (!q[1]) {
 965                                 if (!next) goto no_such_item;
 966                                 return &(next->item);
 967                         }
 968
 969                         q++;    /* ensure we skip the ']' and '.' */
 970
 971                 } else {
 972                         *q = '\0';
 973                         next = cf_section_sub_find(cs, p);
 974                         *q = '.';
 975                 }
 976
 977                 if (!next) break; /* it MAY be a pair in this section! */
 978
 979                 cs = next;
 980                 p = q + 1;
 981         }
 982
 983         if (!*p) goto no_such_item;
 984
 985  retry:
 986         /*
 987          *      Find it in the current referenced
 988          *      section.
 989          */
 990         cp = cf_pair_find(cs, p);
 991         if (cp) {
 992                 cp->parsed = true;      /* conf pairs which are referenced count as parsed */
 993                 return &(cp->item);
 994         }
 995
 996         next = cf_section_sub_find(cs, p);
 997         if (next) return &(next->item);
 998
 999         /*
1000          *      "foo" is "in the current section, OR in main".
1001          */
1002         if ((p == name) && (parentcs != NULL) && (cs != parentcs)) {
1003                 cs = parentcs;
1004                 goto retry;
1005         }
1006
1007 no_such_item:
1008         return NULL;
1009 }
1010
1011
1012 CONF_SECTION *cf_top_section(CONF_SECTION *cs)
1013 {
1014         if (!cs) return NULL;
1015
1016         while (cs->item.parent != NULL) {
1017                 cs = cs->item.parent;
1018         }
1019
1020         return cs;
1021 }
1022
1023
1024 /*
1025  *      Expand the variables in an input string.
1026  */
1027 static char const *cf_expand_variables(char const *cf, int *lineno,
1028                                        CONF_SECTION *outercs,
1029                                        char *output, size_t outsize,
1030                                        char const *input, bool *soft_fail)
1031 {
1032         char *p;
1033         char const *end, *ptr;
1034         CONF_SECTION const *parentcs;
1035         char name[8192];
1036
1037         if (soft_fail) *soft_fail = false;
1038
1039         /*
1040          *      Find the master parent conf section.
1041          *      We can't use main_config.config, because we're in the
1042          *      process of re-building it, and it isn't set up yet...
1043          */
1044         parentcs = cf_top_section(outercs);
1045
1046         p = output;
1047         ptr = input;
1048         while (*ptr) {
1049                 /*
1050                  *      Ignore anything other than "${"
1051                  */
1052                 if ((*ptr == '$') && (ptr[1] == '{')) {
1053                         CONF_ITEM *ci;
1054                         CONF_PAIR *cp;
1055                         char *q;
1056
1057                         /*
1058                          *      FIXME: Add support for ${foo:-bar},
1059                          *      like in xlat.c
1060                          */
1061
1062                         /*
1063                          *      Look for trailing '}', and log a
1064                          *      warning for anything that doesn't match,
1065                          *      and exit with a fatal error.
1066                          */
1067                         end = strchr(ptr, '}');
1068                         if (end == NULL) {
1069                                 *p = '\0';
1070                                 INFO("%s[%d]: Variable expansion missing }",
1071                                        cf, *lineno);
1072                                 return NULL;
1073                         }
1074
1075                         ptr += 2;
1076
1077                         /*
1078                          *      Can't really happen because input lines are
1079                          *      capped at 8k, which is sizeof(name)
1080                          */
1081                         if ((size_t) (end - ptr) >= sizeof(name)) {
1082                                 ERROR("%s[%d]: Reference string is too large",
1083                                       cf, *lineno);
1084                                 return NULL;
1085                         }
1086
1087                         memcpy(name, ptr, end - ptr);
1088                         name[end - ptr] = '\0';
1089
1090                         q = strchr(name, ':');
1091                         if (q) {
1092                                 *(q++) = '\0';
1093                         }
1094
1095                         ci = cf_reference_item(parentcs, outercs, name);
1096                         if (!ci) {
1097                                 if (soft_fail) *soft_fail = true;
1098                                 ERROR("%s[%d]: Reference \"${%s}\" not found", cf, *lineno, name);
1099                                 return NULL;
1100                         }
1101
1102                         /*
1103                          *      The expansion doesn't refer to another item or section
1104                          *      it's the property of a section.
1105                          */
1106                         if (q) {
1107                                 CONF_SECTION *mycs = cf_item_to_section(ci);
1108
1109                                 if (ci->type != CONF_ITEM_SECTION) {
1110                                         ERROR("%s[%d]: Can only reference properties of sections", cf, *lineno);
1111                                         return NULL;
1112                                 }
1113
1114                                 switch (fr_str2int(conf_property_name, q, CONF_PROPERTY_INVALID)) {
1115                                 case CONF_PROPERTY_NAME:
1116                                         strcpy(p, mycs->name1);
1117                                         break;
1118
1119                                 case CONF_PROPERTY_INSTANCE:
1120                                         strcpy(p, mycs->name2 ? mycs->name2 : mycs->name1);
1121                                         break;
1122
1123                                 default:
1124                                         ERROR("%s[%d]: Invalid property '%s'", cf, *lineno, q);
1125                                         return NULL;
1126                                 }
1127                                 p += strlen(p);
1128                                 ptr = end + 1;
1129
1130                         } else if (ci->type == CONF_ITEM_PAIR) {
1131                                 /*
1132                                  *  Substitute the value of the variable.
1133                                  */
1134                                 cp = cf_item_to_pair(ci);
1135
1136                                 /*
1137                                  *      If the thing we reference is
1138                                  *      marked up as being expanded in
1139                                  *      pass2, don't expand it now.
1140                                  *      Let it be expanded in pass2.
1141                                  */
1142                                 if (cp->pass2) {
1143                                         if (soft_fail) *soft_fail = true;
1144
1145                                         ERROR("%s[%d]: Reference \"%s\" points to a variable which has not been expanded.",
1146                                               cf, *lineno, input);
1147                                         return NULL;
1148                                 }
1149
1150                                 if (!cp->value) {
1151                                         ERROR("%s[%d]: Reference \"%s\" has no value",
1152                                                cf, *lineno, input);
1153                                         return NULL;
1154                                 }
1155
1156                                 if (p + strlen(cp->value) >= output + outsize) {
1157                                         ERROR("%s[%d]: Reference \"%s\" is too long",
1158                                                cf, *lineno, input);
1159                                         return NULL;
1160                                 }
1161
1162                                 strcpy(p, cp->value);
1163                                 p += strlen(p);
1164                                 ptr = end + 1;
1165
1166                         } else if (ci->type == CONF_ITEM_SECTION) {
1167                                 CONF_SECTION *subcs;
1168
1169                                 /*
1170                                  *      Adding an entry again to a
1171                                  *      section is wrong.  We don't
1172                                  *      want an infinite loop.
1173                                  */
1174                                 if (ci->parent == outercs) {
1175                                         ERROR("%s[%d]: Cannot reference different item in same section", cf, *lineno);
1176                                         return NULL;
1177                                 }
1178
1179                                 /*
1180                                  *      Copy the section instead of
1181                                  *      referencing it.
1182                                  */
1183                                 subcs = cf_item_to_section(ci);
1184                                 subcs = cf_section_dup(outercs, subcs,
1185                                                        cf_section_name1(subcs), cf_section_name2(subcs),
1186                                                        false);
1187                                 if (!subcs) {
1188                                         ERROR("%s[%d]: Failed copying reference %s", cf, *lineno, name);
1189                                         return NULL;
1190                                 }
1191
1192                                 subcs->item.filename = ci->filename;
1193                                 subcs->item.lineno = ci->lineno;
1194                                 cf_item_add(outercs, &(subcs->item));
1195
1196                                 ptr = end + 1;
1197
1198                         } else {
1199                                 ERROR("%s[%d]: Reference \"%s\" type is invalid", cf, *lineno, input);
1200                                 return NULL;
1201                         }
1202                 } else if (memcmp(ptr, "$ENV{", 5) == 0) {
1203                         char *env;
1204
1205                         ptr += 5;
1206
1207                         /*
1208                          *      Look for trailing '}', and log a
1209                          *      warning for anything that doesn't match,
1210                          *      and exit with a fatal error.
1211                          */
1212                         end = strchr(ptr, '}');
1213                         if (end == NULL) {
1214                                 *p = '\0';
1215                                 INFO("%s[%d]: Environment variable expansion missing }",
1216                                        cf, *lineno);
1217                                 return NULL;
1218                         }
1219
1220                         /*
1221                          *      Can't really happen because input lines are
1222                          *      capped at 8k, which is sizeof(name)
1223                          */
1224                         if ((size_t) (end - ptr) >= sizeof(name)) {
1225                                 ERROR("%s[%d]: Environment variable name is too large",
1226                                        cf, *lineno);
1227                                 return NULL;
1228                         }
1229
1230                         memcpy(name, ptr, end - ptr);
1231                         name[end - ptr] = '\0';
1232
1233                         /*
1234                          *      Get the environment variable.
1235                          *      If none exists, then make it an empty string.
1236                          */
1237                         env = getenv(name);
1238                         if (env == NULL) {
1239                                 *name = '\0';
1240                                 env = name;
1241                         }
1242
1243                         if (p + strlen(env) >= output + outsize) {
1244                                 ERROR("%s[%d]: Reference \"%s\" is too long",
1245                                        cf, *lineno, input);
1246                                 return NULL;
1247                         }
1248
1249                         strcpy(p, env);
1250                         p += strlen(p);
1251                         ptr = end + 1;
1252
1253                 } else {
1254                         /*
1255                          *      Copy it over verbatim.
1256                          */
1257                         *(p++) = *(ptr++);
1258                 }
1259
1260
1261                 if (p >= (output + outsize)) {
1262                         ERROR("%s[%d]: Reference \"%s\" is too long",
1263                                cf, *lineno, input);
1264                         return NULL;
1265                 }
1266         } /* loop over all of the input string. */
1267
1268         *p = '\0';
1269
1270         return output;
1271 }
1272
1273 static char const parse_spaces[] = "                                                                                                                                                                                                                                                                ";
1274
1275 /** Validation function for ipaddr conffile types
1276  *
1277  */
1278 static inline int fr_item_validate_ipaddr(CONF_SECTION *cs, char const *name, PW_TYPE type, char const *value,
1279                                           fr_ipaddr_t *ipaddr)
1280 {
1281         char ipbuf[128];
1282
1283         if (strcmp(value, "*") == 0) {
1284                 cf_log_info(cs, "%.*s\t%s = *", cs->depth, parse_spaces, name);
1285         } else if (strspn(value, ".0123456789abdefABCDEF:%[]/") == strlen(value)) {
1286                 cf_log_info(cs, "%.*s\t%s = %s", cs->depth, parse_spaces, name, value);
1287         } else {
1288                 cf_log_info(cs, "%.*s\t%s = %s IPv%s address [%s]", cs->depth, parse_spaces, name, value,
1289                             (ipaddr->af == AF_INET ? "4" : " 6"), ip_ntoh(ipaddr, ipbuf, sizeof(ipbuf)));
1290         }
1291
1292         switch (type) {
1293         case PW_TYPE_IPV4_ADDR:
1294         case PW_TYPE_IPV6_ADDR:
1295         case PW_TYPE_COMBO_IP_ADDR:
1296                 switch (ipaddr->af) {
1297                 case AF_INET:
1298                 if (ipaddr->prefix != 32) {
1299                         ERROR("Invalid IPv4 mask length \"/%i\".  Only \"/32\" permitted for non-prefix types",
1300                               ipaddr->prefix);
1301
1302                         return -1;
1303                 }
1304                         break;
1305
1306                 case AF_INET6:
1307                 if (ipaddr->prefix != 128) {
1308                         ERROR("Invalid IPv6 mask length \"/%i\".  Only \"/128\" permitted for non-prefix types",
1309                               ipaddr->prefix);
1310
1311                         return -1;
1312                 }
1313                         break;
1314
1315                 default:
1316                         return -1;
1317                 }
1318         default:
1319                 return 0;
1320         }
1321 }
1322
1323 /** Parses a #CONF_PAIR into a C data type, with a default value.
1324  *
1325  * Takes fields from a #CONF_PARSER struct and uses them to parse the string value
1326  * of a #CONF_PAIR into a C data type matching the type argument.
1327  *
1328  * The format of the types are the same as #value_data_t types.
1329  *
1330  * @note The dflt value will only be used if no matching #CONF_PAIR is found. Empty strings will not
1331  *       result in the dflt value being used.
1332  *
1333  * **PW_TYPE to data type mappings**
1334  * | PW_TYPE                 | Data type          | Dynamically allocated  |
1335  * | ----------------------- | ------------------ | ---------------------- |
1336  * | PW_TYPE_TMPL            | ``vp_tmpl_t``      | Yes                    |
1337  * | PW_TYPE_BOOLEAN         | ``bool``           | No                     |
1338  * | PW_TYPE_INTEGER         | ``uint32_t``       | No                     |
1339  * | PW_TYPE_SHORT           | ``uint16_t``       | No                     |
1340  * | PW_TYPE_INTEGER64       | ``uint64_t``       | No                     |
1341  * | PW_TYPE_SIGNED          | ``int32_t``        | No                     |
1342  * | PW_TYPE_STRING          | ``char const *``   | Yes                    |
1343  * | PW_TYPE_IPV4_ADDR       | ``fr_ipaddr_t``    | No                     |
1344  * | PW_TYPE_IPV4_PREFIX     | ``fr_ipaddr_t``    | No                     |
1345  * | PW_TYPE_IPV6_ADDR       | ``fr_ipaddr_t``    | No                     |
1346  * | PW_TYPE_IPV6_PREFIX     | ``fr_ipaddr_t``    | No                     |
1347  * | PW_TYPE_COMBO_IP_ADDR   | ``fr_ipaddr_t``    | No                     |
1348  * | PW_TYPE_COMBO_IP_PREFIX | ``fr_ipaddr_t``    | No                     |
1349  * | PW_TYPE_TIMEVAL         | ``struct timeval`` | No                     |
1350  *
1351  * @param cs to search for matching #CONF_PAIR in.
1352  * @param name of #CONF_PAIR to search for.
1353  * @param type Data type to parse #CONF_PAIR value as.
1354  *      Should be one of the following ``data`` types, and one or more of the following ``flag`` types or'd together:
1355  *      - ``data`` #PW_TYPE_TMPL                - @copybrief PW_TYPE_TMPL
1356  *                                                Feeds the value into #tmpl_afrom_str. Value can be
1357  *                                                obtained when processing requests, with #tmpl_expand or #tmpl_aexpand.
1358  *      - ``data`` #PW_TYPE_BOOLEAN             - @copybrief PW_TYPE_BOOLEAN
1359  *      - ``data`` #PW_TYPE_INTEGER             - @copybrief PW_TYPE_INTEGER
1360  *      - ``data`` #PW_TYPE_SHORT               - @copybrief PW_TYPE_SHORT
1361  *      - ``data`` #PW_TYPE_INTEGER64           - @copybrief PW_TYPE_INTEGER64
1362  *      - ``data`` #PW_TYPE_SIGNED              - @copybrief PW_TYPE_SIGNED
1363  *      - ``data`` #PW_TYPE_STRING              - @copybrief PW_TYPE_STRING
1364  *      - ``data`` #PW_TYPE_IPV4_ADDR           - @copybrief PW_TYPE_IPV4_ADDR (IPv4 address with prefix 32).
1365  *      - ``data`` #PW_TYPE_IPV4_PREFIX         - @copybrief PW_TYPE_IPV4_PREFIX (IPv4 address with variable prefix).
1366  *      - ``data`` #PW_TYPE_IPV6_ADDR           - @copybrief PW_TYPE_IPV6_ADDR (IPv6 address with prefix 128).
1367  *      - ``data`` #PW_TYPE_IPV6_PREFIX         - @copybrief PW_TYPE_IPV6_PREFIX (IPv6 address with variable prefix).
1368  *      - ``data`` #PW_TYPE_COMBO_IP_ADDR       - @copybrief PW_TYPE_COMBO_IP_ADDR (IPv4/IPv6 address with
1369  *                                                prefix 32/128).
1370  *      - ``data`` #PW_TYPE_COMBO_IP_PREFIX     - @copybrief PW_TYPE_COMBO_IP_PREFIX (IPv4/IPv6 address with
1371  *                                                variable prefix).
1372  *      - ``data`` #PW_TYPE_TIMEVAL             - @copybrief PW_TYPE_TIMEVAL
1373  *      - ``flag`` #PW_TYPE_DEPRECATED          - @copybrief PW_TYPE_DEPRECATED
1374  *      - ``flag`` #PW_TYPE_REQUIRED            - @copybrief PW_TYPE_REQUIRED
1375  *      - ``flag`` #PW_TYPE_ATTRIBUTE           - @copybrief PW_TYPE_ATTRIBUTE
1376  *      - ``flag`` #PW_TYPE_SECRET              - @copybrief PW_TYPE_SECRET
1377  *      - ``flag`` #PW_TYPE_FILE_INPUT          - @copybrief PW_TYPE_FILE_INPUT
1378  *      - ``flag`` #PW_TYPE_NOT_EMPTY           - @copybrief PW_TYPE_NOT_EMPTY
1379  * @param data Pointer to a global variable, or pointer to a field in the struct being populated with values.
1380  * @param dflt value to use, if no #CONF_PAIR is found.
1381  * @return
1382  *      - 1 if default value was used.
1383  *      - 0 on success.
1384  *      - -1 on error.
1385  *      - -2 if deprecated.
1386  */
1387 int cf_item_parse(CONF_SECTION *cs, char const *name, unsigned int type, void *data, char const *dflt)
1388 {
1389         int rcode;
1390         bool deprecated, required, attribute, secret, file_input, cant_be_empty, tmpl, multi, file_exists;
1391         char **q;
1392         char const *value;
1393         CONF_PAIR *cp = NULL;
1394         fr_ipaddr_t *ipaddr;
1395         char buffer[8192];
1396         CONF_ITEM *c_item = &cs->item;
1397
1398         if (!cs) return -1;
1399
1400         deprecated = (type & PW_TYPE_DEPRECATED);
1401         required = (type & PW_TYPE_REQUIRED);
1402         attribute = (type & PW_TYPE_ATTRIBUTE);
1403         secret = (type & PW_TYPE_SECRET);
1404         file_input = (type == PW_TYPE_FILE_INPUT);      /* check, not and */
1405         file_exists = (type == PW_TYPE_FILE_EXISTS);    /* check, not and */
1406         cant_be_empty = (type & PW_TYPE_NOT_EMPTY);
1407         tmpl = (type & PW_TYPE_TMPL);
1408         multi = (type & PW_TYPE_MULTI);
1409
1410         if (attribute) required = true;
1411         if (required) cant_be_empty = true;     /* May want to review this in the future... */
1412
1413         /*
1414          *      Everything except templates must have a base type.
1415          */
1416         if (!(type & 0xff) && !tmpl) {
1417                 cf_log_err(c_item, "Configuration item \"%s\" must have a data type", name);
1418                 return -1;
1419         }
1420
1421         type &= 0xff;                           /* normal types are small */
1422
1423         rcode = 0;
1424
1425         cp = cf_pair_find(cs, name);
1426
1427         /*
1428          *      No pairs match the configuration item name in the current
1429          *      section, use the default value.
1430          */
1431         if (!cp) {
1432                 if (deprecated) return 0;       /* Don't set the default value */
1433
1434                 rcode = 1;
1435                 value = dflt;
1436         /*
1437          *      Something matched, used the CONF_PAIR value.
1438          */
1439         } else {
1440                 CONF_PAIR *next = cp;
1441
1442                 value = cp->value;
1443                 cp->parsed = true;
1444                 c_item = &cp->item;
1445
1446                 if (deprecated) {
1447                         cf_log_err(c_item, "Configuration item \"%s\" is deprecated", name);
1448                         return -2;
1449                 }
1450
1451                 /*
1452                  *      A quick check to see if the next item is the same.
1453                  */
1454                 if (!multi && cp->item.next && (cp->item.next->type == CONF_ITEM_PAIR)) {
1455                         next = cf_item_to_pair(cp->item.next);
1456
1457                         if (strcmp(next->attr, name) == 0) {
1458                                 WARN("%s[%d]: Ignoring duplicate configuration item '%s'",
1459                                      next->item.filename ? next->item.filename : "unknown",
1460                                      next->item.lineno, name);
1461                         }
1462                 }
1463
1464                 if (multi) {
1465                         while ((next = cf_pair_find_next(cs, next, name)) != NULL) {
1466                                 /*
1467                                  *      @fixme We should actually validate
1468                                  *      the value of the pairs too
1469                                  */
1470                                 next->parsed = true;
1471                         };
1472                 }
1473         }
1474
1475         if (!value) {
1476                 if (required) {
1477                         cf_log_err(c_item, "Configuration item \"%s\" must have a value", name);
1478
1479                         return -1;
1480                 }
1481                 return rcode;
1482         }
1483
1484         if ((value[0] == '\0') && cant_be_empty) {
1485         cant_be_empty:
1486                 cf_log_err(c_item, "Configuration item \"%s\" must not be empty (zero length)", name);
1487                 if (!required) cf_log_err(c_item, "Comment item to silence this message");
1488
1489                 return -1;
1490         }
1491
1492
1493         /*
1494          *      Process a value as a LITERAL template.  Once all of
1495          *      the attrs and xlats are defined, the pass2 code
1496          *      converts it to the appropriate type.
1497          */
1498         if (tmpl) {
1499                 vp_tmpl_t *vpt;
1500
1501                 if (!value) {
1502                         *(vp_tmpl_t **)data = NULL;
1503                         return 0;
1504                 }
1505
1506                 rad_assert(!attribute);
1507                 vpt = tmpl_alloc(cs, TMPL_TYPE_LITERAL, value, strlen(value));
1508                 *(vp_tmpl_t **)data = vpt;
1509
1510                 return 0;
1511         }
1512
1513         switch (type) {
1514         case PW_TYPE_BOOLEAN:
1515                 /*
1516                  *      Allow yes/no, true/false, and on/off
1517                  */
1518                 if ((strcasecmp(value, "yes") == 0) ||
1519                     (strcasecmp(value, "true") == 0) ||
1520                     (strcasecmp(value, "on") == 0)) {
1521                         *(bool *)data = true;
1522                 } else if ((strcasecmp(value, "no") == 0) ||
1523                            (strcasecmp(value, "false") == 0) ||
1524                            (strcasecmp(value, "off") == 0)) {
1525                         *(bool *)data = false;
1526                 } else {
1527                         *(bool *)data = false;
1528                         cf_log_err(&(cs->item), "Invalid value \"%s\" for boolean "
1529                                "variable %s", value, name);
1530                         return -1;
1531                 }
1532                 cf_log_info(cs, "%.*s\t%s = %s",
1533                             cs->depth, parse_spaces, name, value);
1534                 break;
1535
1536         case PW_TYPE_INTEGER:
1537         {
1538                 unsigned long v = strtoul(value, 0, 0);
1539
1540                 /*
1541                  *      Restrict integer values to 0-INT32_MAX, this means
1542                  *      it will always be safe to cast them to a signed type
1543                  *      for comparisons, and imposes the same range limit as
1544                  *      before we switched to using an unsigned type to
1545                  *      represent config item integers.
1546                  */
1547                 if (v > INT32_MAX) {
1548                         cf_log_err(&(cs->item), "Invalid value \"%s\" for variable %s, must be between 0-%u", value,
1549                                    name, INT32_MAX);
1550                         return -1;
1551                 }
1552
1553                 *(uint32_t *)data = v;
1554                 cf_log_info(cs, "%.*s\t%s = %u", cs->depth, parse_spaces, name, *(uint32_t *)data);
1555         }
1556                 break;
1557
1558         case PW_TYPE_BYTE:
1559         {
1560                 unsigned long v = strtoul(value, 0, 0);
1561
1562                 if (v > UINT8_MAX) {
1563                         cf_log_err(&(cs->item), "Invalid value \"%s\" for variable %s, must be between 0-%u", value,
1564                                    name, UINT8_MAX);
1565                         return -1;
1566                 }
1567                 *(uint8_t *)data = (uint8_t) v;
1568                 cf_log_info(cs, "%.*s\t%s = %u", cs->depth, parse_spaces, name, *(uint8_t *)data);
1569         }
1570                 break;
1571
1572         case PW_TYPE_SHORT:
1573         {
1574                 unsigned long v = strtoul(value, 0, 0);
1575
1576                 if (v > UINT16_MAX) {
1577                         cf_log_err(&(cs->item), "Invalid value \"%s\" for variable %s, must be between 0-%u", value,
1578                                    name, UINT16_MAX);
1579                         return -1;
1580                 }
1581                 *(uint16_t *)data = (uint16_t) v;
1582                 cf_log_info(cs, "%.*s\t%s = %u", cs->depth, parse_spaces, name, *(uint16_t *)data);
1583         }
1584                 break;
1585
1586         case PW_TYPE_INTEGER64:
1587                 *(uint64_t *)data = strtoull(value, 0, 0);
1588                 cf_log_info(cs, "%.*s\t%s = %" PRIu64, cs->depth, parse_spaces, name, *(uint64_t *)data);
1589                 break;
1590
1591         case PW_TYPE_SIGNED:
1592                 *(int32_t *)data = strtol(value, 0, 0);
1593                 cf_log_info(cs, "%.*s\t%s = %d", cs->depth, parse_spaces, name, *(int32_t *)data);
1594                 break;
1595
1596         case PW_TYPE_STRING:
1597                 q = (char **) data;
1598                 if (*q != NULL) {
1599                         talloc_free(*q);
1600                 }
1601
1602                 /*
1603                  *      Expand variables which haven't already been
1604                  *      expanded automagically when the configuration
1605                  *      file was read.
1606                  */
1607                 if (value == dflt) {
1608                         int lineno = 0;
1609
1610                         lineno = cs->item.lineno;
1611
1612                         value = cf_expand_variables("<internal>",
1613                                                     &lineno,
1614                                                     cs, buffer, sizeof(buffer),
1615                                                     value, NULL);
1616                         if (!value) {
1617                                 cf_log_err(&(cs->item),"Failed expanding variable %s", name);
1618                                 return -1;
1619                         }
1620                 }
1621
1622                 if (cant_be_empty && (value[0] == '\0')) goto cant_be_empty;
1623
1624                 if (attribute) {
1625                         if (!dict_attrbyname(value)) {
1626                                 if (!cp) {
1627                                         cf_log_err(&(cs->item), "No such attribute '%s' for configuration '%s'",
1628                                                    value, name);
1629                                 } else {
1630                                         cf_log_err(&(cp->item), "No such attribute '%s'", value);
1631                                 }
1632                                 return -1;
1633                         }
1634                 }
1635
1636                 /*
1637                  *      Hide secrets when using "radiusd -X".
1638                  */
1639                 if (secret && (rad_debug_lvl <= 2)) {
1640                         cf_log_info(cs, "%.*s\t%s = <<< secret >>>",
1641                                     cs->depth, parse_spaces, name);
1642                 } else {
1643                         cf_log_info(cs, "%.*s\t%s = \"%s\"",
1644                                     cs->depth, parse_spaces, name, value ? value : "(null)");
1645                 }
1646                 *q = value ? talloc_typed_strdup(cs, value) : NULL;
1647
1648                 /*
1649                  *      If there's data AND it's an input file, check
1650                  *      that we can read it.  This check allows errors
1651                  *      to be caught as early as possible, during
1652                  *      server startup.
1653                  */
1654                 if (*q && file_input && !cf_file_check(cs, *q, true)) {
1655                         return -1;
1656                 }
1657
1658                 if (*q && file_exists && !cf_file_check(cs, *q, false)) {
1659                         return -1;
1660                 }
1661                 break;
1662
1663         case PW_TYPE_IPV4_ADDR:
1664         case PW_TYPE_IPV4_PREFIX:
1665                 ipaddr = data;
1666
1667                 if (fr_pton4(ipaddr, value, -1, true, false) < 0) {
1668                         ERROR("%s", fr_strerror());
1669                         return -1;
1670                 }
1671                 if (fr_item_validate_ipaddr(cs, name, type, value, ipaddr) < 0) return -1;
1672                 break;
1673
1674         case PW_TYPE_IPV6_ADDR:
1675         case PW_TYPE_IPV6_PREFIX:
1676                 ipaddr = data;
1677
1678                 if (fr_pton6(ipaddr, value, -1, true, false) < 0) {
1679                         ERROR("%s", fr_strerror());
1680                         return -1;
1681                 }
1682                 if (fr_item_validate_ipaddr(cs, name, type, value, ipaddr) < 0) return -1;
1683                 break;
1684
1685         case PW_TYPE_COMBO_IP_ADDR:
1686         case PW_TYPE_COMBO_IP_PREFIX:
1687                 ipaddr = data;
1688
1689                 if (fr_pton(ipaddr, value, -1, AF_UNSPEC, true) < 0) {
1690                         ERROR("%s", fr_strerror());
1691                         return -1;
1692                 }
1693                 if (fr_item_validate_ipaddr(cs, name, type, value, ipaddr) < 0) return -1;
1694                 break;
1695
1696         case PW_TYPE_TIMEVAL: {
1697                 int sec;
1698                 char *end;
1699                 struct timeval tv;
1700
1701                 sec = strtoul(value, &end, 10);
1702                 tv.tv_sec = sec;
1703                 tv.tv_usec = 0;
1704                 if (*end == '.') {
1705                         size_t len;
1706
1707                         len = strlen(end + 1);
1708
1709                         if (len > 6) {
1710                                 ERROR("Too much precision for timeval");
1711                                 return -1;
1712                         }
1713
1714                         /*
1715                          *      If they write "0.1", that means
1716                          *      "10000" microseconds.
1717                          */
1718                         sec = strtoul(end + 1, NULL, 10);
1719                         while (len < 6) {
1720                                 sec *= 10;
1721                                 len++;
1722                         }
1723
1724                         tv.tv_usec = sec;
1725                 }
1726                 cf_log_info(cs, "%.*s\t%s = %d.%06d",
1727                             cs->depth, parse_spaces, name, (int) tv.tv_sec, (int) tv.tv_usec);
1728                 memcpy(data, &tv, sizeof(tv));
1729                 }
1730                 break;
1731
1732         default:
1733                 /*
1734                  *      If we get here, it's a sanity check error.
1735                  *      It's not an error parsing the configuration
1736                  *      file.
1737                  */
1738                 rad_assert(type > PW_TYPE_INVALID);
1739                 rad_assert(type < PW_TYPE_MAX);
1740
1741                 ERROR("type '%s' is not supported in the configuration files",
1742                        fr_int2str(dict_attr_types, type, "?Unknown?"));
1743                 return -1;
1744         } /* switch over variable type */
1745
1746         if (!cp) {
1747                 CONF_PAIR *cpn;
1748
1749                 cpn = cf_pair_alloc(cs, name, value, T_OP_SET, T_BARE_WORD, T_BARE_WORD);
1750                 if (!cpn) return -1;
1751                 cpn->parsed = true;
1752                 cpn->item.filename = "<internal>";
1753                 cpn->item.lineno = 0;
1754                 cf_item_add(cs, &(cpn->item));
1755         }
1756
1757         return rcode;
1758 }
1759
1760
1761 /*
1762  *      A copy of cf_section_parse that initializes pointers before
1763  *      parsing them.
1764  */
1765 static void cf_section_parse_init(CONF_SECTION *cs, void *base,
1766                                   CONF_PARSER const *variables)
1767 {
1768         int i;
1769
1770         for (i = 0; variables[i].name != NULL; i++) {
1771                 if (variables[i].type == PW_TYPE_SUBSECTION) {
1772                         CONF_SECTION *subcs;
1773
1774                         if (!variables[i].dflt) continue;
1775
1776                         subcs = cf_section_sub_find(cs, variables[i].name);
1777
1778                         /*
1779                          *      If there's no subsection in the
1780                          *      config, BUT the CONF_PARSER wants one,
1781                          *      then create an empty one.  This is so
1782                          *      that we can track the strings,
1783                          *      etc. allocated in the subsection.
1784                          */
1785                         if (!subcs) {
1786                                 subcs = cf_section_alloc(cs, variables[i].name, NULL);
1787                                 if (!subcs) return;
1788
1789                                 subcs->item.filename = cs->item.filename;
1790                                 subcs->item.lineno = cs->item.lineno;
1791                                 cf_item_add(cs, &(subcs->item));
1792                         }
1793
1794                         cf_section_parse_init(subcs, (uint8_t *)base + variables[i].offset,
1795                                               (CONF_PARSER const *) variables[i].dflt);
1796                         continue;
1797                 }
1798
1799                 if ((variables[i].type != PW_TYPE_STRING) &&
1800                     (variables[i].type != PW_TYPE_FILE_INPUT) &&
1801                     (variables[i].type != PW_TYPE_FILE_OUTPUT)) {
1802                         continue;
1803                 }
1804
1805                 if (variables[i].data) {
1806                         *(char **) variables[i].data = NULL;
1807                 } else if (base) {
1808                         *(char **) (((char *)base) + variables[i].offset) = NULL;
1809                 } else {
1810                         continue;
1811                 }
1812         } /* for all variables in the configuration section */
1813 }
1814
1815
1816 static void cf_section_parse_warn(CONF_SECTION *cs)
1817 {
1818         CONF_ITEM *ci;
1819
1820         for (ci = cs->children; ci; ci = ci->next) {
1821                 /*
1822                  *      Don't recurse on sections. We can only safely
1823                  *      check conf pairs at the same level as the
1824                  *      section that was just parsed.
1825                  */
1826                 if (ci->type == CONF_ITEM_SECTION) continue;
1827                 if (ci->type == CONF_ITEM_PAIR) {
1828                         CONF_PAIR *cp;
1829
1830                         cp = cf_item_to_pair(ci);
1831                         if (cp->parsed) continue;
1832
1833                         WARN("%s[%d]: The item '%s' is defined, but is unused by the configuration",
1834                              cp->item.filename ? cp->item.filename : "unknown",
1835                              cp->item.lineno ? cp->item.lineno : 0,
1836                                 cp->attr);
1837                 }
1838
1839                 /*
1840                  *      Skip everything else.
1841                  */
1842         }
1843 }
1844
1845 /** Parse a configuration section into user-supplied variables
1846  *
1847  * @param cs to parse.
1848  * @param base pointer to a struct to fill with data.  Any buffers will also be talloced
1849  *      using this parent as a pointer.
1850  * @param variables mappings between struct fields and #CONF_ITEM s.
1851  * @return
1852  *      - 0 on success.
1853  *      - -1 on general error.
1854  *      - -2 if a deprecated #CONF_ITEM was found.
1855  */
1856 int cf_section_parse(CONF_SECTION *cs, void *base, CONF_PARSER const *variables)
1857 {
1858         int ret = 0;
1859         int i;
1860         void *data;
1861
1862         cs->variables = variables; /* this doesn't hurt anything */
1863
1864         if (!cs->name2) {
1865                 cf_log_info(cs, "%.*s%s {", cs->depth, parse_spaces, cs->name1);
1866         } else {
1867                 cf_log_info(cs, "%.*s%s %s {", cs->depth, parse_spaces, cs->name1, cs->name2);
1868         }
1869
1870         cf_section_parse_init(cs, base, variables);
1871
1872         /*
1873          *      Handle the known configuration parameters.
1874          */
1875         for (i = 0; variables[i].name != NULL; i++) {
1876                 /*
1877                  *      Handle subsections specially
1878                  */
1879                 if (variables[i].type == PW_TYPE_SUBSECTION) {
1880                         CONF_SECTION *subcs;
1881
1882                         subcs = cf_section_sub_find(cs, variables[i].name);
1883                         /*
1884                          *      Default in this case is overloaded to mean a pointer
1885                          *      to the CONF_PARSER struct for the subsection.
1886                          */
1887                         if (!variables[i].dflt || !subcs) {
1888                                 ERROR("Internal sanity check 1 failed in cf_section_parse %s", variables[i].name);
1889                                 ret = -1;
1890                                 goto finish;
1891                         }
1892
1893                         ret = cf_section_parse(subcs, (uint8_t *)base + variables[i].offset,
1894                                                (CONF_PARSER const *) variables[i].dflt);
1895                         if (ret < 0) goto finish;
1896                         continue;
1897                 } /* else it's a CONF_PAIR */
1898
1899                 if (variables[i].data) {
1900                         data = variables[i].data; /* prefer this. */
1901                 } else if (base) {
1902                         data = ((char *)base) + variables[i].offset;
1903                 } else {
1904                         ERROR("Internal sanity check 2 failed in cf_section_parse");
1905                         ret = -1;
1906                         goto finish;
1907                 }
1908
1909                 /*
1910                  *      Parse the pair we found, or a default value.
1911                  */
1912                 ret = cf_item_parse(cs, variables[i].name, variables[i].type, data, variables[i].dflt);
1913                 switch (ret) {
1914                 case 1:         /* Used default */
1915                         ret = 0;
1916                         break;
1917
1918                 case 0:         /* OK */
1919                         break;
1920
1921                 case -1:        /* Parse error */
1922                         goto finish;
1923
1924                 case -2:        /* Deprecated CONF ITEM */
1925                         if ((variables[i + 1].offset == variables[i].offset) &&
1926                             (variables[i + 1].data == variables[i].data)) {
1927                                 cf_log_err(&(cs->item), "Replace \"%s\" with \"%s\"", variables[i].name,
1928                                            variables[i + 1].name);
1929                         }
1930                         goto finish;
1931                 }
1932         } /* for all variables in the configuration section */
1933
1934         /*
1935          *      Ensure we have a proper terminator, type so we catch
1936          *      missing terminators reliably
1937          */
1938         rad_assert(variables[i].type == -1);
1939
1940         /*
1941          *      Warn about items in the configuration which weren't
1942          *      checked during parsing.
1943          */
1944         if (rad_debug_lvl >= 3) cf_section_parse_warn(cs);
1945
1946         cs->base = base;
1947
1948         cf_log_info(cs, "%.*s}", cs->depth, parse_spaces);
1949
1950 finish:
1951         return ret;
1952 }
1953
1954
1955 /*
1956  *      Check XLAT things in pass 2.  But don't cache the xlat stuff anywhere.
1957  */
1958 int cf_section_parse_pass2(CONF_SECTION *cs, void *base, CONF_PARSER const *variables)
1959 {
1960         int i;
1961         ssize_t slen;
1962         char const *error;
1963         char *value = NULL;
1964         xlat_exp_t *xlat;
1965
1966         /*
1967          *      Handle the known configuration parameters.
1968          */
1969         for (i = 0; variables[i].name != NULL; i++) {
1970                 CONF_PAIR *cp;
1971                 void *data;
1972
1973                 /*
1974                  *      Handle subsections specially
1975                  */
1976                 if (variables[i].type == PW_TYPE_SUBSECTION) {
1977                         CONF_SECTION *subcs;
1978                         subcs = cf_section_sub_find(cs, variables[i].name);
1979
1980                         if (cf_section_parse_pass2(subcs, (uint8_t *)base + variables[i].offset,
1981                                                    (CONF_PARSER const *) variables[i].dflt) < 0) {
1982                                 return -1;
1983                         }
1984                         continue;
1985                 } /* else it's a CONF_PAIR */
1986
1987                 /*
1988                  *      Figure out which data we need to fix.
1989                  */
1990                 if (variables[i].data) {
1991                         data = variables[i].data; /* prefer this. */
1992                 } else if (base) {
1993                         data = ((char *)base) + variables[i].offset;
1994                 } else {
1995                         data = NULL;
1996                 }
1997
1998                 cp = cf_pair_find(cs, variables[i].name);
1999                 xlat = NULL;
2000
2001         redo:
2002                 if (!cp || !cp->value || !data) continue;
2003
2004                 if ((cp->rhs_type != T_DOUBLE_QUOTED_STRING) &&
2005                     (cp->rhs_type != T_BARE_WORD)) continue;
2006
2007                 /*
2008                  *      Non-xlat expansions shouldn't have xlat!
2009                  */
2010                 if (((variables[i].type & PW_TYPE_XLAT) == 0) &&
2011                     ((variables[i].type & PW_TYPE_TMPL) == 0)) {
2012                         /*
2013                          *      Ignore %{... in shared secrets.
2014                          *      They're never dynamically expanded.
2015                          */
2016                         if ((variables[i].type & PW_TYPE_SECRET) != 0) continue;
2017
2018                         if (strstr(cp->value, "%{") != NULL) {
2019                                 WARN("%s[%d]: Found dynamic expansion in string which will not be dynamically expanded",
2020                                      cp->item.filename ? cp->item.filename : "unknown",
2021                                      cp->item.lineno ? cp->item.lineno : 0);
2022                         }
2023                         continue;
2024                 }
2025
2026                 /*
2027                  *      Parse (and throw away) the xlat string.
2028                  *
2029                  *      FIXME: All of these should be converted from PW_TYPE_XLAT
2030                  *      to PW_TYPE_TMPL.
2031                  */
2032                 if ((variables[i].type & PW_TYPE_XLAT) != 0) {
2033                         /*
2034                          *      xlat expansions should be parseable.
2035                          */
2036                         value = talloc_strdup(cs, cp->value); /* modified by xlat_tokenize */
2037                         xlat = NULL;
2038
2039                         slen = xlat_tokenize(cs, value, &xlat, &error);
2040                         if (slen < 0) {
2041                                 char *spaces, *text;
2042
2043                         error:
2044                                 fr_canonicalize_error(cs, &spaces, &text, slen, cp->value);
2045
2046                                 cf_log_err(&cp->item, "Failed parsing expanded string:");
2047                                 cf_log_err(&cp->item, "%s", text);
2048                                 cf_log_err(&cp->item, "%s^ %s", spaces, error);
2049
2050                                 talloc_free(spaces);
2051                                 talloc_free(text);
2052                                 talloc_free(value);
2053                                 talloc_free(xlat);
2054                                 return -1;
2055                         }
2056
2057                         talloc_free(value);
2058                         talloc_free(xlat);
2059                 }
2060
2061                 /*
2062                  *      Convert the LITERAL template to the actual
2063                  *      type.
2064                  */
2065                 if ((variables[i].type & PW_TYPE_TMPL) != 0) {
2066                         vp_tmpl_t *vpt;
2067
2068                         slen = tmpl_afrom_str(cs, &vpt, cp->value, talloc_array_length(cp->value) - 1,
2069                                               cp->rhs_type,
2070                                               REQUEST_CURRENT, PAIR_LIST_REQUEST, true);
2071                         if (slen < 0) {
2072                                 error = fr_strerror();
2073                                 goto error;
2074                         }
2075
2076                         /*
2077                          *      Sanity check
2078                          *
2079                          *      Don't add default - update with new types.
2080                          */
2081                         switch (vpt->type) {
2082                         /*
2083                          *      All attributes should have been defined by this point.
2084                          */
2085                         case TMPL_TYPE_ATTR_UNDEFINED:
2086                                 cf_log_err(&cp->item, "Unknown attribute '%s'", vpt->tmpl_unknown_name);
2087                                 return -1;
2088
2089                         case TMPL_TYPE_LITERAL:
2090                         case TMPL_TYPE_ATTR:
2091                         case TMPL_TYPE_LIST:
2092                         case TMPL_TYPE_DATA:
2093                         case TMPL_TYPE_EXEC:
2094                         case TMPL_TYPE_XLAT:
2095                         case TMPL_TYPE_XLAT_STRUCT:
2096                                 break;
2097
2098                         case TMPL_TYPE_UNKNOWN:
2099                         case TMPL_TYPE_REGEX:
2100                         case TMPL_TYPE_REGEX_STRUCT:
2101                         case TMPL_TYPE_NULL:
2102                                 rad_assert(0);
2103                         }
2104
2105                         talloc_free(*(vp_tmpl_t **)data);
2106                         *(vp_tmpl_t **)data = vpt;
2107                 }
2108
2109                 /*
2110                  *      If the "multi" flag is set, check all of them.
2111                  */
2112                 if ((variables[i].type & PW_TYPE_MULTI) != 0) {
2113                         cp = cf_pair_find_next(cs, cp, cp->attr);
2114                         goto redo;
2115                 }
2116         } /* for all variables in the configuration section */
2117
2118         return 0;
2119 }
2120
2121 /*
2122  *      Merge the template so everyting else "just works".
2123  */
2124 static bool cf_template_merge(CONF_SECTION *cs, CONF_SECTION const *template)
2125 {
2126         CONF_ITEM *ci;
2127
2128         if (!cs || !template) return true;
2129
2130         cs->template = NULL;
2131
2132         /*
2133          *      Walk over the template, adding its' entries to the
2134          *      current section.  But only if the entries don't
2135          *      already exist in the current section.
2136          */
2137         for (ci = template->children; ci; ci = ci->next) {
2138                 if (ci->type == CONF_ITEM_PAIR) {
2139                         CONF_PAIR *cp1, *cp2;
2140
2141                         /*
2142                          *      It exists, don't over-write it.
2143                          */
2144                         cp1 = cf_item_to_pair(ci);
2145                         if (cf_pair_find(cs, cp1->attr)) {
2146                                 continue;
2147                         }
2148
2149                         /*
2150                          *      Create a new pair with all of the data
2151                          *      of the old one.
2152                          */
2153                         cp2 = cf_pair_dup(cs, cp1);
2154                         if (!cp2) return false;
2155
2156                         cp2->item.filename = cp1->item.filename;
2157                         cp2->item.lineno = cp1->item.lineno;
2158
2159                         cf_item_add(cs, &(cp2->item));
2160                         continue;
2161                 }
2162
2163                 if (ci->type == CONF_ITEM_SECTION) {
2164                         CONF_SECTION *subcs1, *subcs2;
2165
2166                         subcs1 = cf_item_to_section(ci);
2167                         rad_assert(subcs1 != NULL);
2168
2169                         subcs2 = cf_section_sub_find_name2(cs, subcs1->name1, subcs1->name2);
2170                         if (subcs2) {
2171                                 /*
2172                                  *      sub-sections get merged.
2173                                  */
2174                                 if (!cf_template_merge(subcs2, subcs1)) {
2175                                         return false;
2176                                 }
2177                                 continue;
2178                         }
2179
2180                         /*
2181                          *      Our section doesn't have a matching
2182                          *      sub-section.  Copy it verbatim from
2183                          *      the template.
2184                          */
2185                         subcs2 = cf_section_dup(cs, subcs1,
2186                                                 cf_section_name1(subcs1), cf_section_name2(subcs1),
2187                                                 false);
2188                         if (!subcs2) return false;
2189
2190                         subcs2->item.filename = subcs1->item.filename;
2191                         subcs2->item.lineno = subcs1->item.lineno;
2192
2193                         cf_item_add(cs, &(subcs2->item));
2194                         continue;
2195                 }
2196
2197                 /* ignore everything else */
2198         }
2199
2200         return true;
2201 }
2202
2203 static char const *cf_local_file(char const *base, char const *filename,
2204                                  char *buffer, size_t bufsize)
2205 {
2206         size_t dirsize;
2207         char *p;
2208
2209         strlcpy(buffer, base, bufsize);
2210
2211         p = strrchr(buffer, FR_DIR_SEP);
2212         if (!p) return filename;
2213         if (p[1]) {             /* ./foo */
2214                 p[1] = '\0';
2215         }
2216
2217         dirsize = (p - buffer) + 1;
2218
2219         if ((dirsize + strlen(filename)) >= bufsize) {
2220                 return NULL;
2221         }
2222
2223         strlcpy(p + 1, filename, bufsize - dirsize);
2224
2225         return buffer;
2226 }
2227
2228
2229 /*
2230  *      Read a part of the config file.
2231  */
2232 static int cf_section_read(char const *filename, int *lineno, FILE *fp,
2233                            CONF_SECTION *current)
2234
2235 {
2236         CONF_SECTION *this, *css;
2237         CONF_PAIR *cpn;
2238         char const *ptr;
2239         char const *value;
2240         char buf[8192];
2241         char buf1[8192];
2242         char buf2[8192];
2243         char buf3[8192];
2244         char buf4[8192];
2245         FR_TOKEN t1 = T_INVALID, t2, t3;
2246         bool has_spaces = false;
2247         bool pass2;
2248         char *cbuf = buf;
2249         size_t len;
2250
2251         this = current;         /* add items here */
2252
2253         /*
2254          *      Read, checking for line continuations ('\\' at EOL)
2255          */
2256         for (;;) {
2257                 int at_eof;
2258                 css = NULL;
2259
2260                 /*
2261                  *      Get data, and remember if we are at EOF.
2262                  */
2263                 at_eof = (fgets(cbuf, sizeof(buf) - (cbuf - buf), fp) == NULL);
2264                 (*lineno)++;
2265
2266                 /*
2267                  *      We read the entire 8k worth of data: complain.
2268                  *      Note that we don't care if the last character
2269                  *      is \n: it's still forbidden.  This means that
2270                  *      the maximum allowed length of text is 8k-1, which
2271                  *      should be plenty.
2272                  */
2273                 len = strlen(cbuf);
2274                 if ((cbuf + len + 1) >= (buf + sizeof(buf))) {
2275                         ERROR("%s[%d]: Line too long",
2276                                filename, *lineno);
2277                         return -1;
2278                 }
2279
2280                 if (has_spaces) {
2281                         ptr = cbuf;
2282                         while (isspace((int) *ptr)) ptr++;
2283
2284                         if (ptr > cbuf) {
2285                                 memmove(cbuf, ptr, len - (ptr - cbuf));
2286                                 len -= (ptr - cbuf);
2287                         }
2288                 }
2289
2290                 /*
2291                  *      Not doing continuations: check for edge
2292                  *      conditions.
2293                  */
2294                 if (cbuf == buf) {
2295                         if (at_eof) break;
2296
2297                         ptr = buf;
2298                         while (*ptr && isspace((int) *ptr)) ptr++;
2299
2300                         if (!*ptr || (*ptr == '#')) continue;
2301
2302                 } else if (at_eof || (len == 0)) {
2303                         ERROR("%s[%d]: Continuation at EOF is illegal",
2304                                filename, *lineno);
2305                         return -1;
2306                 }
2307
2308                 /*
2309                  *      See if there's a continuation.
2310                  */
2311                 while ((len > 0) &&
2312                        ((cbuf[len - 1] == '\n') || (cbuf[len - 1] == '\r'))) {
2313                         len--;
2314                         cbuf[len] = '\0';
2315                 }
2316
2317                 if ((len > 0) && (cbuf[len - 1] == '\\')) {
2318                         /*
2319                          *      Check for "suppress spaces" magic.
2320                          */
2321                         if (!has_spaces && (len > 2) && (cbuf[len - 2] == '"')) {
2322                                 has_spaces = true;
2323                         }
2324
2325                         cbuf[len - 1] = '\0';
2326                         cbuf += len - 1;
2327                         continue;
2328                 }
2329
2330                 ptr = cbuf = buf;
2331                 has_spaces = false;
2332
2333         get_more:
2334                 pass2 = false;
2335
2336                 /*
2337                  *      The parser is getting to be evil.
2338                  */
2339                 while ((*ptr == ' ') || (*ptr == '\t')) ptr++;
2340
2341                 if (((ptr[0] == '%') && (ptr[1] == '{')) ||
2342                     (ptr[0] == '`')) {
2343                         int hack;
2344
2345                         if (ptr[0] == '%') {
2346                                 hack = rad_copy_variable(buf1, ptr);
2347                         } else {
2348                                 hack = rad_copy_string(buf1, ptr);
2349                         }
2350                         if (hack < 0) {
2351                                 ERROR("%s[%d]: Invalid expansion: %s",
2352                                        filename, *lineno, ptr);
2353                                 return -1;
2354                         }
2355
2356                         ptr += hack;
2357
2358                         t2 = gettoken(&ptr, buf2, sizeof(buf2), true);
2359                         switch (t2) {
2360                         case T_EOL:
2361                         case T_HASH:
2362                                 goto do_bare_word;
2363
2364                         default:
2365                                 ERROR("%s[%d]: Invalid expansion: %s",
2366                                        filename, *lineno, ptr);
2367                                 return -1;
2368                         }
2369                 } else {
2370                         t1 = gettoken(&ptr, buf1, sizeof(buf1), true);
2371                 }
2372
2373                 /*
2374                  *      The caller eats "name1 name2 {", and calls us
2375                  *      for the data inside of the section.  So if we
2376                  *      receive a closing brace, then it must mean the
2377                  *      end of the section.
2378                  */
2379                if (t1 == T_RCBRACE) {
2380                        if (this == current) {
2381                                ERROR("%s[%d]: Too many closing braces",
2382                                       filename, *lineno);
2383                                return -1;
2384                        }
2385
2386                        /*
2387                         *       Merge the template into the existing
2388                         *       section.  This uses more memory, but
2389                         *       means that templates now work with
2390                         *       sub-sections, etc.
2391                         */
2392                        if (!cf_template_merge(this, this->template)) {
2393                                return -1;
2394                        }
2395
2396                        this = this->item.parent;
2397                        goto check_for_more;
2398                }
2399
2400                if (t1 != T_BARE_WORD) goto skip_keywords;
2401
2402                 /*
2403                  *      Allow for $INCLUDE files
2404                  *
2405                  *      This *SHOULD* work for any level include.
2406                  *      I really really really hate this file.  -cparker
2407                  */
2408                if ((strcasecmp(buf1, "$INCLUDE") == 0) ||
2409                    (strcasecmp(buf1, "$-INCLUDE") == 0)) {
2410                         bool relative = true;
2411
2412                         t2 = getword(&ptr, buf2, sizeof(buf2), true);
2413                         if (t2 != T_EOL) {
2414                                ERROR("%s[%d]: Unexpected text after $INCLUDE",
2415                                      filename, *lineno);
2416                                return -1;
2417                         }
2418
2419                         if (buf2[0] == '$') relative = false;
2420
2421                         value = cf_expand_variables(filename, lineno, this, buf4, sizeof(buf4), buf2, NULL);
2422                         if (!value) return -1;
2423
2424                         if (!FR_DIR_IS_RELATIVE(value)) relative = false;
2425
2426                         if (relative) {
2427                                 value = cf_local_file(filename, value, buf3,
2428                                                       sizeof(buf3));
2429                                 if (!value) {
2430                                         ERROR("%s[%d]: Directories too deep.",
2431                                                filename, *lineno);
2432                                         return -1;
2433                                 }
2434                         }
2435
2436
2437 #ifdef HAVE_DIRENT_H
2438                         /*
2439                          *      $INCLUDE foo/
2440                          *
2441                          *      Include ALL non-"dot" files in the directory.
2442                          *      careful!
2443                          */
2444                         if (value[strlen(value) - 1] == '/') {
2445                                 DIR             *dir;
2446                                 struct dirent   *dp;
2447                                 struct stat stat_buf;
2448
2449                                 DEBUG2("including files in directory %s", value );
2450 #ifdef S_IWOTH
2451                                 /*
2452                                  *      Security checks.
2453                                  */
2454                                 if (stat(value, &stat_buf) < 0) {
2455                                         ERROR("%s[%d]: Failed reading directory %s: %s",
2456                                                filename, *lineno,
2457                                                value, fr_syserror(errno));
2458                                         return -1;
2459                                 }
2460
2461                                 if ((stat_buf.st_mode & S_IWOTH) != 0) {
2462                                         ERROR("%s[%d]: Directory %s is globally writable.  Refusing to start due to "
2463                                               "insecure configuration", filename, *lineno, value);
2464                                         return -1;
2465                                 }
2466 #endif
2467                                 dir = opendir(value);
2468                                 if (!dir) {
2469                                         ERROR("%s[%d]: Error reading directory %s: %s",
2470                                                filename, *lineno, value,
2471                                                fr_syserror(errno));
2472                                         return -1;
2473                                 }
2474
2475                                 /*
2476                                  *      Read the directory, ignoring "." files.
2477                                  */
2478                                 while ((dp = readdir(dir)) != NULL) {
2479                                         char const *p;
2480
2481                                         if (dp->d_name[0] == '.') continue;
2482
2483                                         /*
2484                                          *      Check for valid characters
2485                                          */
2486                                         for (p = dp->d_name; *p != '\0'; p++) {
2487                                                 if (isalpha((int)*p) ||
2488                                                     isdigit((int)*p) ||
2489                                                     (*p == '-') ||
2490                                                     (*p == '_') ||
2491                                                     (*p == '.')) continue;
2492                                                 break;
2493                                         }
2494                                         if (*p != '\0') continue;
2495
2496                                         snprintf(buf2, sizeof(buf2), "%s%s",
2497                                                  value, dp->d_name);
2498                                         if ((stat(buf2, &stat_buf) != 0) ||
2499                                             S_ISDIR(stat_buf.st_mode)) continue;
2500                                         /*
2501                                          *      Read the file into the current
2502                                          *      configuration section.
2503                                          */
2504                                         if (cf_file_include(this, buf2) < 0) {
2505                                                 closedir(dir);
2506                                                 return -1;
2507                                         }
2508                                 }
2509                                 closedir(dir);
2510                         }  else
2511 #endif
2512                         { /* it was a normal file */
2513                                 if (buf1[1] == '-') {
2514                                         struct stat statbuf;
2515
2516                                         if (stat(value, &statbuf) < 0) {
2517                                                 WARN("Not including file %s: %s", value, fr_syserror(errno));
2518                                                 continue;
2519                                         }
2520                                 }
2521
2522                                 if (cf_file_include(this, value) < 0) {
2523                                         return -1;
2524                                 }
2525                         }
2526                         continue;
2527                 } /* we were in an include */
2528
2529                if (strcasecmp(buf1, "$template") == 0) {
2530                        CONF_ITEM *ci;
2531                        CONF_SECTION *parentcs, *templatecs;
2532                        t2 = getword(&ptr, buf2, sizeof(buf2), true);
2533
2534                        if (t2 != T_EOL) {
2535                                ERROR("%s[%d]: Unexpected text after $TEMPLATE", filename, *lineno);
2536                                return -1;
2537                        }
2538
2539                        parentcs = cf_top_section(current);
2540
2541                        templatecs = cf_section_sub_find(parentcs, "templates");
2542                        if (!templatecs) {
2543                                 ERROR("%s[%d]: No \"templates\" section for reference \"%s\"", filename, *lineno, buf2);
2544                                 return -1;
2545                        }
2546
2547                        ci = cf_reference_item(parentcs, templatecs, buf2);
2548                        if (!ci || (ci->type != CONF_ITEM_SECTION)) {
2549                                 ERROR("%s[%d]: Reference \"%s\" not found", filename, *lineno, buf2);
2550                                 return -1;
2551                        }
2552
2553                        if (!this) {
2554                                 ERROR("%s[%d]: Internal sanity check error in template reference", filename, *lineno);
2555                                 return -1;
2556                        }
2557
2558                        if (this->template) {
2559                                 ERROR("%s[%d]: Section already has a template", filename, *lineno);
2560                                 return -1;
2561                        }
2562
2563                        this->template = cf_item_to_section(ci);
2564                        continue;
2565                }
2566
2567                 /*
2568                  *      Ensure that the user can't add CONF_PAIRs
2569                  *      with 'internal' names;
2570                  */
2571                 if (buf1[0] == '_') {
2572                         ERROR("%s[%d]: Illegal configuration pair name \"%s\"", filename, *lineno, buf1);
2573                         return -1;
2574                 }
2575
2576                 /*
2577                  *      Handle if/elsif specially.
2578                  */
2579                 if ((strcmp(buf1, "if") == 0) || (strcmp(buf1, "elsif") == 0)) {
2580                         ssize_t slen;
2581                         char const *error = NULL;
2582                         char *p;
2583                         CONF_SECTION *server;
2584                         fr_cond_t *cond = NULL;
2585
2586                         /*
2587                          *      if / elsif MUST be inside of a
2588                          *      processing section, which MUST in turn
2589                          *      be inside of a "server" directive.
2590                          */
2591                         if (!this->item.parent) {
2592                         invalid_location:
2593                                 ERROR("%s[%d]: Invalid location for '%s'",
2594                                        filename, *lineno, buf1);
2595                                 return -1;
2596                         }
2597
2598                         /*
2599                          *      Can only have "if" in 3 named sections.
2600                          */
2601                         server = this->item.parent;
2602                         while (server &&
2603                                (strcmp(server->name1, "server") != 0) &&
2604                                (strcmp(server->name1, "policy") != 0) &&
2605                                (strcmp(server->name1, "instantiate") != 0)) {
2606                                 server = server->item.parent;
2607                                 if (!server) goto invalid_location;
2608                         }
2609
2610                         /*
2611                          *      Skip (...) to find the {
2612                          */
2613                         slen = fr_condition_tokenize(this, cf_section_to_item(this), ptr, &cond,
2614                                                      &error, FR_COND_TWO_PASS);
2615                         memcpy(&p, &ptr, sizeof(p));
2616
2617                         if (slen < 0) {
2618                                 if (p[-slen] != '{') goto cond_error;
2619                                 slen = -slen;
2620                         }
2621                         TALLOC_FREE(cond);
2622
2623                         /*
2624                          *      This hack is so that the NEXT stage
2625                          *      doesn't go "too far" in expanding the
2626                          *      variable.  We can parse the conditions
2627                          *      without expanding the ${...} stuff.
2628                          *      BUT we don't want to expand all of the
2629                          *      stuff AFTER the condition.  So we do
2630                          *      two passes.
2631                          *
2632                          *      The first pass is to discover the end
2633                          *      of the condition.  We then expand THAT
2634                          *      string, and do a second pass parsing
2635                          *      the expanded condition.
2636                          */
2637                         p += slen;
2638                         *p = '\0';
2639
2640                         /*
2641                          *      If there's a ${...}.  If so, expand it.
2642                          */
2643                         if (strchr(ptr, '$') != NULL) {
2644                                 ptr = cf_expand_variables(filename, lineno,
2645                                                           this,
2646                                                           buf3, sizeof(buf3),
2647                                                           ptr, NULL);
2648                                 if (!ptr) {
2649                                         ERROR("%s[%d]: Parse error expanding ${...} in condition",
2650                                               filename, *lineno);
2651                                         return -1;
2652                                 }
2653                         } /* else leave it alone */
2654
2655                         css = cf_section_alloc(this, buf1, ptr);
2656                         if (!css) {
2657                                 ERROR("%s[%d]: Failed allocating memory for section",
2658                                       filename, *lineno);
2659                                 return -1;
2660                         }
2661                         css->item.filename = filename;
2662                         css->item.lineno = *lineno;
2663
2664                         slen = fr_condition_tokenize(css, cf_section_to_item(css), ptr, &cond,
2665                                                      &error, FR_COND_TWO_PASS);
2666                         *p = '{'; /* put it back */
2667
2668                 cond_error:
2669                         if (slen < 0) {
2670                                 char *spaces, *text;
2671
2672                                 fr_canonicalize_error(this, &spaces, &text, slen, ptr);
2673
2674                                 ERROR("%s[%d]: Parse error in condition",
2675                                       filename, *lineno);
2676                                 ERROR("%s[%d]: %s", filename, *lineno, text);
2677                                 ERROR("%s[%d]: %s^ %s", filename, *lineno, spaces, error);
2678
2679                                 talloc_free(spaces);
2680                                 talloc_free(text);
2681                                 talloc_free(css);
2682                                 return -1;
2683                         }
2684
2685                         if ((size_t) slen >= (sizeof(buf2) - 1)) {
2686                                 talloc_free(css);
2687                                 ERROR("%s[%d]: Condition is too large after \"%s\"",
2688                                        filename, *lineno, buf1);
2689                                 return -1;
2690                         }
2691
2692                         /*
2693                          *      Copy the expanded and parsed condition
2694                          *      into buf2.  Then, parse the text after
2695                          *      the condition, which now MUST be a '{.
2696                          *
2697                          *      If it wasn't '{' it would have been
2698                          *      caught in the first pass of
2699                          *      conditional parsing, above.
2700                          */
2701                         memcpy(buf2, ptr, slen);
2702                         buf2[slen] = '\0';
2703                         ptr = p;
2704
2705                         if ((t3 = gettoken(&ptr, buf3, sizeof(buf3), true)) != T_LCBRACE) {
2706                                 talloc_free(css);
2707                                 ERROR("%s[%d]: Expected '{' %d",
2708                                       filename, *lineno, t3);
2709                                 return -1;
2710                         }
2711
2712                         /*
2713                          *      Swap the condition with trailing stuff for
2714                          *      the final condition.
2715                          */
2716                         memcpy(&p, &css->name2, sizeof(css->name2));
2717                         talloc_free(p);
2718                         css->name2 = talloc_typed_strdup(css, buf2);
2719
2720                         cf_item_add(this, &(css->item));
2721                         cf_data_add_internal(css, "if", cond, NULL, false);
2722
2723                         /*
2724                          *      The current section is now the child section.
2725                          */
2726                         this = css;
2727                         css = NULL;
2728                         goto check_for_more;
2729                 }
2730
2731         skip_keywords:
2732                 /*
2733                  *      Grab the next token.
2734                  */
2735                 t2 = gettoken(&ptr, buf2, sizeof(buf2), !cf_new_escape);
2736                 switch (t2) {
2737                 case T_EOL:
2738                 case T_HASH:
2739                 case T_COMMA:
2740                 do_bare_word:
2741                         t3 = t2;
2742                         t2 = T_OP_EQ;
2743                         value = NULL;
2744                         goto do_set;
2745
2746                 case T_OP_INCRM:
2747                 case T_OP_ADD:
2748                 case T_OP_CMP_EQ:
2749                 case T_OP_SUB:
2750                 case T_OP_LE:
2751                 case T_OP_GE:
2752                 case T_OP_CMP_FALSE:
2753                         if (!this || (strcmp(this->name1, "update") != 0)) {
2754                                 ERROR("%s[%d]: Invalid operator in assignment",
2755                                        filename, *lineno);
2756                                 return -1;
2757                         }
2758                         /* FALL-THROUGH */
2759
2760                 case T_OP_EQ:
2761                 case T_OP_SET:
2762                         while (isspace((int) *ptr)) ptr++;
2763
2764                         /*
2765                          *      New parser: non-quoted strings are
2766                          *      bare words, and we parse everything
2767                          *      until the next newline, or the next
2768                          *      comma.  If they have { or } in a bare
2769                          *      word, well... too bad.
2770                          */
2771                         if (cf_new_escape && (*ptr != '"') && (*ptr != '\'')
2772                             && (*ptr != '`') && (*ptr != '/')) {
2773                                 const char *q = ptr;
2774
2775                                 t3 = T_BARE_WORD;
2776                                 while (*q && (*q >= ' ') && (*q != ',') &&
2777                                        !isspace(*q)) q++;
2778
2779                                 if ((size_t) (q - ptr) >= sizeof(buf3)) {
2780                                         ERROR("%s[%d]: Parse error: value too long",
2781                                               filename, *lineno);
2782                                         return -1;
2783                                 }
2784
2785                                 memcpy(buf3, ptr, (q - ptr));
2786                                 buf3[q - ptr] = '\0';
2787                                 ptr = q;
2788
2789                         } else {
2790                                 t3 = getstring(&ptr, buf3, sizeof(buf3), !cf_new_escape);
2791                         }
2792
2793                         if (t3 == T_INVALID) {
2794                                 ERROR("%s[%d]: Parse error: %s",
2795                                        filename, *lineno,
2796                                        fr_strerror());
2797                                 return -1;
2798                         }
2799
2800                         /*
2801                          *      Allow "foo" by itself, or "foo = bar"
2802                          */
2803                         switch (t3) {
2804                                 bool soft_fail;
2805
2806                         case T_BARE_WORD:
2807                         case T_DOUBLE_QUOTED_STRING:
2808                         case T_BACK_QUOTED_STRING:
2809                                 value = cf_expand_variables(filename, lineno, this, buf4, sizeof(buf4), buf3, &soft_fail);
2810                                 if (!value) {
2811                                         if (!soft_fail) return -1;
2812
2813                                         /*
2814                                          *      References an item which doesn't exist,
2815                                          *      or which is already marked up as being
2816                                          *      expanded in pass2.  Wait for pass2 to
2817                                          *      do the expansions.
2818                                          */
2819                                         pass2 = true;
2820                                         value = buf3;
2821                                 }
2822                                 break;
2823
2824                         case T_EOL:
2825                         case T_HASH:
2826                                 value = NULL;
2827                                 break;
2828
2829                         default:
2830                                 value = buf3;
2831                                 break;
2832                         }
2833
2834                         /*
2835                          *      Add this CONF_PAIR to our CONF_SECTION
2836                          */
2837                 do_set:
2838                         cpn = cf_pair_alloc(this, buf1, value, t2, t1, t3);
2839                         if (!cpn) return -1;
2840                         cpn->item.filename = filename;
2841                         cpn->item.lineno = *lineno;
2842                         cpn->pass2 = pass2;
2843                         cf_item_add(this, &(cpn->item));
2844
2845                         /*
2846                          *      Hacks for escaping
2847                          */
2848                         if (!cf_new_escape && !this->item.parent && value &&
2849                             (strcmp(buf1, "correct_escapes") == 0) &&
2850                             ((strcmp(value, "true") == 0) ||
2851                              (strcmp(value, "yes") == 0) ||
2852                              (strcmp(value, "1") == 0))) {
2853                                 cf_new_escape = true;
2854                         }
2855
2856                         /*
2857                          *      Require a comma, unless there's a comment.
2858                          */
2859                         while (isspace(*ptr)) ptr++;
2860
2861                         if (*ptr == ',') {
2862                                 ptr++;
2863                                 break;
2864                         }
2865
2866                         /*
2867                          *      module # stuff!
2868                          *      foo = bar # other stuff
2869                          */
2870                         if ((t3 == T_HASH) || (t3 == T_COMMA) || (t3 == T_EOL) || (*ptr == '#')) continue;
2871
2872                         if (!*ptr || (*ptr == '}')) break;
2873
2874                         ERROR("%s[%d]: Syntax error: Expected comma after '%s': %s",
2875                               filename, *lineno, value, ptr);
2876                         return -1;
2877
2878                         /*
2879                          *      No '=', must be a section or sub-section.
2880                          */
2881                 case T_BARE_WORD:
2882                 case T_DOUBLE_QUOTED_STRING:
2883                 case T_SINGLE_QUOTED_STRING:
2884                         t3 = gettoken(&ptr, buf3, sizeof(buf3), true);
2885                         if (t3 != T_LCBRACE) {
2886                                 ERROR("%s[%d]: Expecting section start brace '{' after \"%s %s\"",
2887                                        filename, *lineno, buf1, buf2);
2888                                 return -1;
2889                         }
2890                         /* FALL-THROUGH */
2891
2892                 case T_LCBRACE:
2893                         css = cf_section_alloc(this, buf1,
2894                                                t2 == T_LCBRACE ? NULL : buf2);
2895                         if (!css) {
2896                                 ERROR("%s[%d]: Failed allocating memory for section",
2897                                       filename, *lineno);
2898                                 return -1;
2899                         }
2900
2901                         css->item.filename = filename;
2902                         css->item.lineno = *lineno;
2903                         cf_item_add(this, &(css->item));
2904
2905                         /*
2906                          *      There may not be a name2
2907                          */
2908                         css->name2_type = (t2 == T_LCBRACE) ? T_INVALID : t2;
2909
2910                         /*
2911                          *      The current section is now the child section.
2912                          */
2913                         this = css;
2914                         break;
2915
2916                 case T_INVALID:
2917                         ERROR("%s[%d]: Syntax error in '%s': %s", filename, *lineno, ptr, fr_strerror());
2918
2919                         return -1;
2920
2921                 default:
2922                         ERROR("%s[%d]: Parse error after \"%s\": unexpected token \"%s\"",
2923                               filename, *lineno, buf1, fr_int2str(fr_tokens, t2, "<INVALID>"));
2924
2925                         return -1;
2926                 }
2927
2928         check_for_more:
2929                 /*
2930                  *      Done parsing one thing.  Skip to EOL if possible.
2931                  */
2932                 while (isspace(*ptr)) ptr++;
2933
2934                 if (*ptr == '#') continue;
2935
2936                 if (*ptr) {
2937                         goto get_more;
2938                 }
2939
2940         }
2941
2942         /*
2943          *      See if EOF was unexpected ..
2944          */
2945         if (feof(fp) && (this != current)) {
2946                 ERROR("%s[%d]: EOF reached without closing brace for section %s starting at line %d",
2947                       filename, *lineno, cf_section_name1(this), cf_section_lineno(this));
2948                 return -1;
2949         }
2950
2951         return 0;
2952 }
2953
2954 /*
2955  *      Include one config file in another.
2956  */
2957 static int cf_file_include(CONF_SECTION *cs, char const *filename_in)
2958 {
2959         FILE            *fp;
2960         int             lineno = 0;
2961         char const      *filename;
2962
2963         /*
2964          *      So we only need to do this once.
2965          */
2966         filename = talloc_strdup(cs, filename_in);
2967
2968         DEBUG2("including configuration file %s", filename);
2969
2970         fp = cf_file_open(cs, filename);
2971         if (!fp) return -1;
2972
2973         if (!cs->item.filename) cs->item.filename = filename;
2974
2975         /*
2976          *      Read the section.  It's OK to have EOF without a
2977          *      matching close brace.
2978          */
2979         if (cf_section_read(filename, &lineno, fp, cs) < 0) {
2980                 fclose(fp);
2981                 return -1;
2982         }
2983
2984         fclose(fp);
2985         return 0;
2986 }
2987
2988
2989 /*
2990  *      Do variable expansion in pass2.
2991  *
2992  *      This is a breadth-first expansion.  "deep
2993  */
2994 static int cf_section_pass2(CONF_SECTION *cs)
2995 {
2996         CONF_ITEM *ci;
2997
2998         for (ci = cs->children; ci; ci = ci->next) {
2999                 char const *value;
3000                 CONF_PAIR *cp;
3001                 char buffer[8192];
3002
3003                 if (ci->type != CONF_ITEM_PAIR) continue;
3004
3005                 cp = cf_item_to_pair(ci);
3006                 if (!cp->value || !cp->pass2) continue;
3007
3008                 rad_assert((cp->rhs_type == T_BARE_WORD) ||
3009                            (cp->rhs_type == T_DOUBLE_QUOTED_STRING) ||
3010                            (cp->rhs_type == T_BACK_QUOTED_STRING));
3011
3012                 value = cf_expand_variables(ci->filename, &ci->lineno, cs, buffer, sizeof(buffer), cp->value, NULL);
3013                 if (!value) return -1;
3014
3015                 rad_const_free(cp->value);
3016                 cp->value = talloc_typed_strdup(cp, value);
3017         }
3018
3019         for (ci = cs->children; ci; ci = ci->next) {
3020                 if (ci->type != CONF_ITEM_SECTION) continue;
3021
3022                 if (cf_section_pass2(cf_item_to_section(ci)) < 0) return -1;
3023         }
3024
3025         return 0;
3026 }
3027
3028
3029 /*
3030  *      Bootstrap a config file.
3031  */
3032 int cf_file_read(CONF_SECTION *cs, char const *filename)
3033 {
3034         char *p;
3035         CONF_PAIR *cp;
3036         rbtree_t *tree;
3037
3038         cp = cf_pair_alloc(cs, "confdir", filename, T_OP_SET, T_BARE_WORD, T_SINGLE_QUOTED_STRING);
3039         if (!cp) return -1;
3040
3041         p = strrchr(cp->value, FR_DIR_SEP);
3042         if (p) *p = '\0';
3043
3044         cp->item.filename = "<internal>";
3045         cp->item.lineno = -1;
3046         cf_item_add(cs, &(cp->item));
3047
3048         tree = rbtree_create(cs, filename_cmp, NULL, 0);
3049         if (!tree) return -1;
3050
3051         cf_data_add_internal(cs, "filename", tree, NULL, 0);
3052
3053         if (cf_file_include(cs, filename) < 0) return -1;
3054
3055         /*
3056          *      Now that we've read the file, go back through it and
3057          *      expand the variables.
3058          */
3059         if (cf_section_pass2(cs) < 0) return -1;
3060
3061         return 0;
3062 }
3063
3064
3065 void cf_file_free(CONF_SECTION *cs)
3066 {
3067         talloc_free(cs);
3068 }
3069
3070
3071 /*
3072  * Return a CONF_PAIR within a CONF_SECTION.
3073  */
3074 CONF_PAIR *cf_pair_find(CONF_SECTION const *cs, char const *name)
3075 {
3076         CONF_PAIR *cp, mycp;
3077
3078         if (!cs || !name) return NULL;
3079
3080         mycp.attr = name;
3081         cp = rbtree_finddata(cs->pair_tree, &mycp);
3082         if (cp) return cp;
3083
3084         if (!cs->template) return NULL;
3085
3086         return rbtree_finddata(cs->template->pair_tree, &mycp);
3087 }
3088
3089 /*
3090  * Return the attr of a CONF_PAIR
3091  */
3092
3093 char const *cf_pair_attr(CONF_PAIR const *pair)
3094 {
3095         return (pair ? pair->attr : NULL);
3096 }
3097
3098 /*
3099  * Return the value of a CONF_PAIR
3100  */
3101
3102 char const *cf_pair_value(CONF_PAIR const *pair)
3103 {
3104         return (pair ? pair->value : NULL);
3105 }
3106
3107 FR_TOKEN cf_pair_operator(CONF_PAIR const *pair)
3108 {
3109         return (pair ? pair->op : T_INVALID);
3110 }
3111
3112 /** Return the value (lhs) type
3113  *
3114  * @param pair to extract value type from.
3115  * @return one of T_BARE_WORD, T_SINGLE_QUOTED_STRING, T_BACK_QUOTED_STRING
3116  *      T_DOUBLE_QUOTED_STRING or T_INVALID if the pair is NULL.
3117  */
3118 FR_TOKEN cf_pair_attr_type(CONF_PAIR const *pair)
3119 {
3120         return (pair ? pair->lhs_type : T_INVALID);
3121 }
3122
3123 /** Return the value (rhs) type
3124  *
3125  * @param pair to extract value type from.
3126  * @return one of T_BARE_WORD, T_SINGLE_QUOTED_STRING, T_BACK_QUOTED_STRING
3127  *      T_DOUBLE_QUOTED_STRING or T_INVALID if the pair is NULL.
3128  */
3129 FR_TOKEN cf_pair_value_type(CONF_PAIR const *pair)
3130 {
3131         return (pair ? pair->rhs_type : T_INVALID);
3132 }
3133
3134 /*
3135  * Turn a CONF_PAIR into a VALUE_PAIR
3136  * For now, ignore the "value_type" field...
3137  */
3138 VALUE_PAIR *cf_pairtovp(CONF_PAIR *pair)
3139 {
3140         if (!pair) {
3141                 fr_strerror_printf("Internal error");
3142                 return NULL;
3143         }
3144
3145         if (!pair->value) {
3146                 fr_strerror_printf("No value given for attribute %s", pair->attr);
3147                 return NULL;
3148         }
3149
3150         /*
3151          *      false comparisons never match.  BUT if it's a "string"
3152          *      or `string`, then remember to expand it later.
3153          */
3154         if ((pair->op != T_OP_CMP_FALSE) &&
3155             ((pair->rhs_type == T_DOUBLE_QUOTED_STRING) ||
3156              (pair->rhs_type == T_BACK_QUOTED_STRING))) {
3157                 VALUE_PAIR *vp;
3158
3159                 vp = fr_pair_make(pair, NULL, pair->attr, NULL, pair->op);
3160                 if (!vp) {
3161                         return NULL;
3162                 }
3163
3164                 if (fr_pair_mark_xlat(vp, pair->value) < 0) {
3165                         talloc_free(vp);
3166
3167                         return NULL;
3168                 }
3169
3170                 return vp;
3171         }
3172
3173         return fr_pair_make(pair, NULL, pair->attr, pair->value, pair->op);
3174 }
3175
3176 /*
3177  * Return the first label of a CONF_SECTION
3178  */
3179
3180 char const *cf_section_name1(CONF_SECTION const *cs)
3181 {
3182         return (cs ? cs->name1 : NULL);
3183 }
3184
3185 /*
3186  * Return the second label of a CONF_SECTION
3187  */
3188
3189 char const *cf_section_name2(CONF_SECTION const *cs)
3190 {
3191         return (cs ? cs->name2 : NULL);
3192 }
3193
3194 /** Return name2 if set, else name1
3195  *
3196  */
3197 char const *cf_section_name(CONF_SECTION const *cs)
3198 {
3199         char const *name;
3200
3201         name = cf_section_name2(cs);
3202         if (name) return name;
3203
3204         return cf_section_name1(cs);
3205 }
3206
3207 /*
3208  * Find a value in a CONF_SECTION
3209  */
3210 char const *cf_section_value_find(CONF_SECTION const *cs, char const *attr)
3211 {
3212         CONF_PAIR       *cp;
3213
3214         cp = cf_pair_find(cs, attr);
3215
3216         return (cp ? cp->value : NULL);
3217 }
3218
3219
3220 CONF_SECTION *cf_section_find_name2(CONF_SECTION const *cs,
3221                                     char const *name1, char const *name2)
3222 {
3223         char const      *their2;
3224         CONF_ITEM const *ci;
3225
3226         if (!cs || !name1) return NULL;
3227
3228         for (ci = &(cs->item); ci; ci = ci->next) {
3229                 if (ci->type != CONF_ITEM_SECTION)
3230                         continue;
3231
3232                 if (strcmp(cf_item_to_section(ci)->name1, name1) != 0) {
3233                         continue;
3234                 }
3235
3236                 their2 = cf_item_to_section(ci)->name2;
3237
3238                 if ((!name2 && !their2) ||
3239                     (name2 && their2 && (strcmp(name2, their2) == 0))) {
3240                         return cf_item_to_section(ci);
3241                 }
3242         }
3243
3244         return NULL;
3245 }
3246
3247 /** Find a pair with a name matching attr, after specified pair.
3248  *
3249  * @param cs to search in.
3250  * @param pair to search from (may be NULL).
3251  * @param attr to find (may be NULL in which case any attribute matches).
3252  * @return the next matching CONF_PAIR or NULL if none matched.
3253  */
3254 CONF_PAIR *cf_pair_find_next(CONF_SECTION const *cs,
3255                              CONF_PAIR const *pair, char const *attr)
3256 {
3257         CONF_ITEM       *ci;
3258
3259         if (!cs) return NULL;
3260
3261         /*
3262          *      If pair is NULL and we're trying to find a specific
3263          *      attribute this must be a first time run.
3264          *
3265          *      Find the pair with correct name.
3266          */
3267         if (!pair && attr) return cf_pair_find(cs, attr);
3268
3269         /*
3270          *      Start searching from the next child, or from the head
3271          *      of the list of children (if no pair was provided).
3272          */
3273         for (ci = pair ? pair->item.next : cs->children;
3274              ci;
3275              ci = ci->next) {
3276                 if (ci->type != CONF_ITEM_PAIR) continue;
3277
3278                 if (!attr || strcmp(cf_item_to_pair(ci)->attr, attr) == 0) break;
3279         }
3280
3281         return cf_item_to_pair(ci);
3282 }
3283
3284 /*
3285  * Find a CONF_SECTION, or return the root if name is NULL
3286  */
3287
3288 CONF_SECTION *cf_section_find(char const *name)
3289 {
3290         if (name)
3291                 return cf_section_sub_find(root_config, name);
3292         else
3293                 return root_config;
3294 }
3295
3296 /** Find a sub-section in a section
3297  *
3298  *      This finds ANY section having the same first name.
3299  *      The second name is ignored.
3300  */
3301 CONF_SECTION *cf_section_sub_find(CONF_SECTION const *cs, char const *name)
3302 {
3303         CONF_SECTION mycs;
3304
3305         if (!cs || !name) return NULL;  /* can't find an un-named section */
3306
3307         /*
3308          *      No sub-sections have been defined, so none exist.
3309          */
3310         if (!cs->section_tree) return NULL;
3311
3312         mycs.name1 = name;
3313         mycs.name2 = NULL;
3314         return rbtree_finddata(cs->section_tree, &mycs);
3315 }
3316
3317
3318 /** Find a CONF_SECTION with both names.
3319  *
3320  */
3321 CONF_SECTION *cf_section_sub_find_name2(CONF_SECTION const *cs,
3322                                         char const *name1, char const *name2)
3323 {
3324         CONF_ITEM    *ci;
3325
3326         if (!cs) cs = root_config;
3327         if (!cs) return NULL;
3328
3329         if (name1) {
3330                 CONF_SECTION mycs, *master_cs;
3331
3332                 if (!cs->section_tree) return NULL;
3333
3334                 mycs.name1 = name1;
3335                 mycs.name2 = name2;
3336
3337                 master_cs = rbtree_finddata(cs->section_tree, &mycs);
3338                 if (!master_cs) return NULL;
3339
3340                 /*
3341                  *      Look it up in the name2 tree.  If it's there,
3342                  *      return it.
3343                  */
3344                 if (master_cs->name2_tree) {
3345                         CONF_SECTION *subcs;
3346
3347                         subcs = rbtree_finddata(master_cs->name2_tree, &mycs);
3348                         if (subcs) return subcs;
3349                 }
3350
3351                 /*
3352                  *      We don't insert ourselves into the name2 tree.
3353                  *      So if there's nothing in the name2 tree, maybe
3354                  *      *we* are the answer.
3355                  */
3356                 if (!master_cs->name2 && name2) return NULL;
3357                 if (master_cs->name2 && !name2) return NULL;
3358                 if (!master_cs->name2 && !name2) return master_cs;
3359
3360                 if (strcmp(master_cs->name2, name2) == 0) {
3361                         return master_cs;
3362                 }
3363
3364                 return NULL;
3365         }
3366
3367         /*
3368          *      Else do it the old-fashioned way.
3369          */
3370         for (ci = cs->children; ci; ci = ci->next) {
3371                 CONF_SECTION *subcs;
3372
3373                 if (ci->type != CONF_ITEM_SECTION)
3374                         continue;
3375
3376                 subcs = cf_item_to_section(ci);
3377                 if (!subcs->name2) {
3378                         if (strcmp(subcs->name1, name2) == 0) break;
3379                 } else {
3380                         if (strcmp(subcs->name2, name2) == 0) break;
3381                 }
3382         }
3383
3384         return cf_item_to_section(ci);
3385 }
3386
3387 /*
3388  * Return the next subsection after a CONF_SECTION
3389  * with a certain name1 (char *name1). If the requested
3390  * name1 is NULL, any name1 matches.
3391  */
3392
3393 CONF_SECTION *cf_subsection_find_next(CONF_SECTION const *section,
3394                                       CONF_SECTION const *subsection,
3395                                       char const *name1)
3396 {
3397         CONF_ITEM       *ci;
3398
3399         if (!section) return NULL;
3400
3401         /*
3402          * If subsection is NULL this must be a first time run
3403          * Find the subsection with correct name
3404          */
3405
3406         if (!subsection) {
3407                 ci = section->children;
3408         } else {
3409                 ci = subsection->item.next;
3410         }
3411
3412         for (; ci; ci = ci->next) {
3413                 if (ci->type != CONF_ITEM_SECTION)
3414                         continue;
3415                 if ((name1 == NULL) ||
3416                     (strcmp(cf_item_to_section(ci)->name1, name1) == 0))
3417                         break;
3418         }
3419
3420         return cf_item_to_section(ci);
3421 }
3422
3423
3424 /*
3425  * Return the next section after a CONF_SECTION
3426  * with a certain name1 (char *name1). If the requested
3427  * name1 is NULL, any name1 matches.
3428  */
3429
3430 CONF_SECTION *cf_section_find_next(CONF_SECTION const *section,
3431                                    CONF_SECTION const *subsection,
3432                                    char const *name1)
3433 {
3434         if (!section) return NULL;
3435
3436         if (!section->item.parent) return NULL;
3437
3438         return cf_subsection_find_next(section->item.parent, subsection, name1);
3439 }
3440
3441 /** Return the next item after a CONF_ITEM.
3442  *
3443  */
3444 CONF_ITEM *cf_item_find_next(CONF_SECTION const *section, CONF_ITEM const *item)
3445 {
3446         if (!section) return NULL;
3447
3448         /*
3449          *      If item is NULL this must be a first time run
3450          *      Return the first item
3451          */
3452         if (item == NULL) {
3453                 return section->children;
3454         } else {
3455                 return item->next;
3456         }
3457 }
3458
3459 static void _pair_count(int *count, CONF_SECTION const *cs)
3460 {
3461         CONF_ITEM const *ci;
3462
3463         for (ci = cf_item_find_next(cs, NULL);
3464              ci != NULL;
3465              ci = cf_item_find_next(cs, ci)) {
3466
3467                 if (cf_item_is_section(ci)) {
3468                         _pair_count(count, cf_item_to_section(ci));
3469                         continue;
3470                 }
3471
3472                 (*count)++;
3473         }
3474 }
3475
3476 /** Count the number of conf pairs beneath a section
3477  *
3478  * @param[in] cs to search for items in.
3479  * @return number of pairs nested within section.
3480  */
3481 int cf_pair_count(CONF_SECTION const *cs)
3482 {
3483         int count = 0;
3484
3485         _pair_count(&count, cs);
3486
3487         return count;
3488 }
3489
3490 CONF_SECTION *cf_item_parent(CONF_ITEM const *ci)
3491 {
3492         if (!ci) return NULL;
3493
3494         return ci->parent;
3495 }
3496
3497 int cf_section_lineno(CONF_SECTION const *section)
3498 {
3499         return section->item.lineno;
3500 }
3501
3502 char const *cf_pair_filename(CONF_PAIR const *pair)
3503 {
3504         return pair->item.filename;
3505 }
3506
3507 char const *cf_section_filename(CONF_SECTION const *section)
3508 {
3509         return section->item.filename;
3510 }
3511
3512 int cf_pair_lineno(CONF_PAIR const *pair)
3513 {
3514         return pair->item.lineno;
3515 }
3516
3517 bool cf_item_is_section(CONF_ITEM const *item)
3518 {
3519         return item->type == CONF_ITEM_SECTION;
3520 }
3521
3522 bool cf_item_is_pair(CONF_ITEM const *item)
3523 {
3524         return item->type == CONF_ITEM_PAIR;
3525 }
3526
3527
3528 static CONF_DATA *cf_data_alloc(CONF_SECTION *parent, char const *name,
3529                                 void *data, void (*data_free)(void *))
3530 {
3531         CONF_DATA *cd;
3532
3533         cd = talloc_zero(parent, CONF_DATA);
3534         if (!cd) return NULL;
3535
3536         cd->item.type = CONF_ITEM_DATA;
3537         cd->item.parent = parent;
3538         cd->name = talloc_typed_strdup(cd, name);
3539         if (!cd->name) {
3540                 talloc_free(cd);
3541                 return NULL;
3542         }
3543
3544         cd->data = data;
3545         cd->free = data_free;
3546
3547         if (cd->free) {
3548                 talloc_set_destructor(cd, _cf_data_free);
3549         }
3550
3551         return cd;
3552 }
3553
3554 static void *cf_data_find_internal(CONF_SECTION const *cs, char const *name, int flag)
3555 {
3556         if (!cs || !name) return NULL;
3557
3558         /*
3559          *      Find the name in the tree, for speed.
3560          */
3561         if (cs->data_tree) {
3562                 CONF_DATA mycd;
3563
3564                 mycd.name = name;
3565                 mycd.flag = flag;
3566                 return rbtree_finddata(cs->data_tree, &mycd);
3567         }
3568
3569         return NULL;
3570 }
3571
3572 /*
3573  *      Find data from a particular section.
3574  */
3575 void *cf_data_find(CONF_SECTION const *cs, char const *name)
3576 {
3577         CONF_DATA *cd = cf_data_find_internal(cs, name, 0);
3578
3579         if (cd) return cd->data;
3580         return NULL;
3581 }
3582
3583
3584 /*
3585  *      Add named data to a configuration section.
3586  */
3587 static int cf_data_add_internal(CONF_SECTION *cs, char const *name,
3588                                 void *data, void (*data_free)(void *),
3589                                 int flag)
3590 {
3591         CONF_DATA *cd;
3592
3593         if (!cs || !name) return -1;
3594
3595         /*
3596          *      Already exists.  Can't add it.
3597          */
3598         if (cf_data_find_internal(cs, name, flag) != NULL) return -1;
3599
3600         cd = cf_data_alloc(cs, name, data, data_free);
3601         if (!cd) return -1;
3602         cd->flag = flag;
3603
3604         cf_item_add(cs, cf_data_to_item(cd));
3605
3606         return 0;
3607 }
3608
3609 /*
3610  *      Add named data to a configuration section.
3611  */
3612 int cf_data_add(CONF_SECTION *cs, char const *name,
3613                 void *data, void (*data_free)(void *))
3614 {
3615         return cf_data_add_internal(cs, name, data, data_free, 0);
3616 }
3617
3618 /** Remove named data from a configuration section
3619  *
3620  */
3621 void *cf_data_remove(CONF_SECTION *cs, char const *name)
3622 {
3623         CONF_DATA mycd;
3624         CONF_DATA *cd;
3625         CONF_ITEM *ci, *it;
3626         void *data;
3627
3628         if (!cs || !name) return NULL;
3629         if (!cs->data_tree) return NULL;
3630
3631         /*
3632          *      Find the name in the tree, for speed.
3633          */
3634         mycd.name = name;
3635         mycd.flag = 0;
3636         cd = rbtree_finddata(cs->data_tree, &mycd);
3637         if (!cd) return NULL;
3638
3639         ci = cf_data_to_item(cd);
3640         if (cs->children == ci) {
3641                 cs->children = ci->next;
3642                 if (cs->tail == ci) cs->tail = NULL;
3643         } else {
3644                 for (it = cs->children; it; it = it->next) {
3645                         if (it->next == ci) {
3646                                 it->next = ci->next;
3647                                 if (cs->tail == ci) cs->tail = it;
3648                                 break;
3649                         }
3650                 }
3651         }
3652
3653         talloc_set_destructor(cd, NULL);        /* Disarm the destructor */
3654         rbtree_deletebydata(cs->data_tree, &mycd);
3655
3656         data = cd->data;
3657         talloc_free(cd);
3658
3659         return data;
3660 }
3661
3662 /*
3663  *      This is here to make the rest of the code easier to read.  It
3664  *      ties conffile.c to log.c, but it means we don't have to
3665  *      pollute every other function with the knowledge of the
3666  *      configuration internals.
3667  */
3668 void cf_log_err(CONF_ITEM const *ci, char const *fmt, ...)
3669 {
3670         va_list ap;
3671         char buffer[256];
3672
3673         va_start(ap, fmt);
3674         vsnprintf(buffer, sizeof(buffer), fmt, ap);
3675         va_end(ap);
3676
3677         if (ci) {
3678                 ERROR("%s[%d]: %s",
3679                        ci->filename ? ci->filename : "unknown",
3680                        ci->lineno ? ci->lineno : 0,
3681                        buffer);
3682         } else {
3683                 ERROR("<unknown>[*]: %s", buffer);
3684         }
3685 }
3686
3687 void cf_log_err_cs(CONF_SECTION const *cs, char const *fmt, ...)
3688 {
3689         va_list ap;
3690         char buffer[256];
3691
3692         va_start(ap, fmt);
3693         vsnprintf(buffer, sizeof(buffer), fmt, ap);
3694         va_end(ap);
3695
3696         rad_assert(cs != NULL);
3697
3698         ERROR("%s[%d]: %s",
3699                cs->item.filename ? cs->item.filename : "unknown",
3700                cs->item.lineno ? cs->item.lineno : 0,
3701                buffer);
3702 }
3703
3704 void cf_log_err_cp(CONF_PAIR const *cp, char const *fmt, ...)
3705 {
3706         va_list ap;
3707         char buffer[256];
3708
3709         va_start(ap, fmt);
3710         vsnprintf(buffer, sizeof(buffer), fmt, ap);
3711         va_end(ap);
3712
3713         rad_assert(cp != NULL);
3714
3715         ERROR("%s[%d]: %s",
3716                cp->item.filename ? cp->item.filename : "unknown",
3717                cp->item.lineno ? cp->item.lineno : 0,
3718                buffer);
3719 }
3720
3721 void cf_log_info(CONF_SECTION const *cs, char const *fmt, ...)
3722 {
3723         va_list ap;
3724
3725         va_start(ap, fmt);
3726         if ((rad_debug_lvl > 1) && cs) vradlog(L_DBG, fmt, ap);
3727         va_end(ap);
3728 }
3729
3730 /*
3731  *      Wrapper to simplify the code.
3732  */
3733 void cf_log_module(CONF_SECTION const *cs, char const *fmt, ...)
3734 {
3735         va_list ap;
3736         char buffer[256];
3737
3738         va_start(ap, fmt);
3739         if (rad_debug_lvl > 1 && cs) {
3740                 vsnprintf(buffer, sizeof(buffer), fmt, ap);
3741
3742                 DEBUG("%.*s# %s", cs->depth, parse_spaces, buffer);
3743         }
3744         va_end(ap);
3745 }
3746
3747 const CONF_PARSER *cf_section_parse_table(CONF_SECTION *cs)
3748 {
3749         if (!cs) return NULL;
3750
3751         return cs->variables;
3752 }
3753
3754 /*
3755  *      For "switch" and "case" statements.
3756  */
3757 FR_TOKEN cf_section_name2_type(CONF_SECTION const *cs)
3758 {
3759         if (!cs) return T_INVALID;
3760
3761         return cs->name2_type;
3762 }