Remove always-false condition from cf_item_parse
authorAlan T. DeKok <aland@freeradius.org>
Tue, 14 Mar 2017 23:41:13 +0000 (19:41 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Tue, 14 Mar 2017 23:45:09 +0000 (19:45 -0400)
src/main/conffile.c

index df78184..10c029a 100644 (file)
@@ -1474,7 +1474,6 @@ int cf_item_parse(CONF_SECTION *cs, char const *name, unsigned int type, void *d
 
        if (!value) {
                if (required) {
-               is_required:
                        cf_log_err(c_item, "Configuration item \"%s\" must have a value", name);
 
                        return -1;
@@ -1620,7 +1619,6 @@ int cf_item_parse(CONF_SECTION *cs, char const *name, unsigned int type, void *d
                        }
                }
 
-               if (required && !value) goto is_required;
                if (cant_be_empty && (value[0] == '\0')) goto cant_be_empty;
 
                if (attribute) {